Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3501106imu; Mon, 7 Jan 2019 04:39:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/U2i1pTbf6iXg6vUwURMO+L+v3A7I2jIjDCeDxRRW1ryOjaKk+msncjtcQQO5kJyeopLt+P X-Received: by 2002:a62:670f:: with SMTP id b15mr62577432pfc.212.1546864773993; Mon, 07 Jan 2019 04:39:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546864773; cv=none; d=google.com; s=arc-20160816; b=YBT1B+YrbOPvLbyfk7+ydamJxUSc+6rfxbZay8EkdfhmHEXWpU0k/q+cSy2fT3CMhP aeW1a/5wyZ3SRT9JWrf+SapkfH6burhJNphHuO+l87npx6DGGTfpzSOWamyXzx+zdpxm YkZbievIUjA9DJhW47NH70ffhx3Gq8hd/ZzQ45hnyHMSmSl+CNBetFPLgVt31q6BMReY E/hQwJm54Aju8KouSMSfY5VroBgxk8d/D3r+k9zLaDfHDbHkcaK32nA158GcwubyMVTn RpZT1Cd2Ir4u7HCSxWPZFSsO/2xcV1BybS9ofK12/4vgVekD6DN7UTEFhA5kGl70kPHh xnOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gn0OeEMlZ17fC6brx5UJwNnq+zPzUl/1PvBABD4yShI=; b=UFqYa3c8NVnGTY2lTa/BeAHo0+iH4qlne28zLLi1CA9wusJuzbkfo7FNjo26XBrL2k uMQHZnHisLamj204xOoFwWnbh8fN1AKwv1OmCy/0++nrFEd8HKDcYG7g6jOQqO2IsffC veXKlzGCb9h3qBGdot2kfUyHBLiPy90EDS1BIfV/uMOG3mTmW3IkDrLA+cgJKWS6BvN0 r9Q6BKgYMttmdeWTSWdgiDfOPlTEWVN3FS1fsVTK6PXkNwxAQKJtUMRff7aG4PLxR9Kq ch1JomzZ7mn56Ooa1r6zxXNCX8Zrmqz+wsn2NigQPwmqrJHN4f85V1K45Xux+JJ4lX7J OyRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BgvzkUxt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8si59133482pll.187.2019.01.07.04.39.18; Mon, 07 Jan 2019 04:39:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BgvzkUxt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbfAGMhg (ORCPT + 99 others); Mon, 7 Jan 2019 07:37:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:52452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727577AbfAGMh3 (ORCPT ); Mon, 7 Jan 2019 07:37:29 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE008206BB; Mon, 7 Jan 2019 12:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864648; bh=FaB3XAFPBCyym3VorNEEgW5/OMhhKmF7GkqM3BV6DPE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BgvzkUxtJ3tESTK+wHatktU3ZzmZtCuNhh8aGR5TO0cGZlw9ObKtUCCWTiMwq586c qDbJYOUJjnkfVGkYpTbMG0K24Vo8lWA8yVqdNhttXg5nC0XLhxklWdLGURQwkuNZjq 93tX0epFHbTsR1TOOKVnMjTFIeVmb0cSEDZs6+wI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eugeniy Paltsev , Daniel Vetter Subject: [PATCH 4.20 062/145] DRM: UDL: get rid of useless vblank initialization Date: Mon, 7 Jan 2019 13:31:39 +0100 Message-Id: <20190107104445.339741360@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eugeniy Paltsev commit 32e932e37e6b6e13b66add307192c7ddd40a781d upstream. UDL doesn't support vblank functionality so we don't need to initialize vblank here (we are able to send page flip completion events even without vblank initialization) Moreover current drm_vblank_init call with num_crtcs > 0 causes sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every time. This breaks userspace apps (for example weston) which relies on timestamp value. Cc: stable@vger.kernel.org Signed-off-by: Eugeniy Paltsev Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/udl/udl_main.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *d if (ret) goto err; - ret = drm_vblank_init(dev, 1); - if (ret) - goto err_fb; - drm_kms_helper_poll_init(dev); return 0; -err_fb: - udl_fbdev_cleanup(dev); + err: if (udl->urbs.count) udl_free_urb_list(dev);