Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3505283imu; Mon, 7 Jan 2019 04:44:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN6y9LlAtBgkM3sd044/twHdjKitO8xqy3SwKFL+KO07ifQEFLng3nvSaSdMtabRcUJhxPiA X-Received: by 2002:a17:902:a601:: with SMTP id u1mr60941963plq.77.1546865072799; Mon, 07 Jan 2019 04:44:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546865072; cv=none; d=google.com; s=arc-20160816; b=JOpAKanb+KDfnx40T7UjxH2K914eC+u2iD174Eyc52P5DbnNAXEEn/Ip/0KWsO15c+ txlVOKjQ4/q2W9s0Zsry/Om+HHJhbg/iE6zrnPTwwQ7ax4qBbi8E907khYuZa90JhNSI LZJJnNDqi8eqSiTKt1t7YAaxaDGEisx916lxHwpYbImVRCBYcKi4sh4j5SNY4D4BOTJ8 IyNbFYV/egOIwWi3BGehpJtgqEwRQgQg9jVm7RjWEocF5IUlYyIEDzB0x9uVp/4acIUJ bxXB30R7Lp2LQfiwOdQ28SPuJTApjnIu2jPH3pl9UqzUhS7mH/b+HHUKPWvWzJjQ1DIX 7Mzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cIsPkn+T/y7xR3UXwUeTOrijbxboaCgB8h37dOyqAI0=; b=hjrX++k+z0nV/M+PmPfE1rFU/JsT6Eu5vl+Q0StBIvOESREiTlMgivUFxziewt4qU8 0IjGSx3eoVEpibH7VAacv9nSiq93v7V7c78skw+B2mW5Q3zP4acQweaLYiCGQ1iUxwTp tjYSEvbg2fqTthshqe4VoR35zp+v36tOQC/Ymc/oJ54aFvw4/PopoRqbeliUCx5LWMAQ Gx4KaZUx93XYMKfbWAJm6fGmC83/0LB7H+pIWikRfnnEj44WXIlz2byjkQb4bWqRlWdx aQpP1NYa3HZ3a5ciWzJBT3HyZVxiYChTEorBow3EpNQEQ+c3Vw/pUGTg5BOiZiDdgFWL y6jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vzReoezP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si30851395plq.138.2019.01.07.04.44.17; Mon, 07 Jan 2019 04:44:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vzReoezP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728290AbfAGMmc (ORCPT + 99 others); Mon, 7 Jan 2019 07:42:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:58174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727767AbfAGMm3 (ORCPT ); Mon, 7 Jan 2019 07:42:29 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD3442070C; Mon, 7 Jan 2019 12:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864948; bh=bJhpL+vMbhQfLB4We2y5Hrr3KueG7/Q0q0pNEoupGhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vzReoezP3FDroNFMn9IJgy/XodeQ8iS/GoAC7GQpux4om0tjmgWFeJ9ivX7kRWvvU E9aDy59iCSOKBqiNUaaKXnlKqb65T3EvyzJ+9YxZbVo6B8wSkaPUc0iap6Z8baa20I CujOD6o4jannG/45QhW93J8A0SmHMOwzOfq75mig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chao Yu , Jaegeuk Kim Subject: [PATCH 4.20 106/145] f2fs: fix missing unlock(sbi->gc_mutex) Date: Mon, 7 Jan 2019 13:32:23 +0100 Message-Id: <20190107104451.120257789@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jaegeuk Kim commit 8f31b4665c14fe19593601a250275e58c7ad0ef1 upstream. This fixes missing unlock call. Cc: Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/super.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1457,19 +1457,16 @@ static int f2fs_disable_checkpoint(struc sbi->sb->s_flags |= SB_ACTIVE; - mutex_lock(&sbi->gc_mutex); f2fs_update_time(sbi, DISABLE_TIME); while (!f2fs_time_over(sbi, DISABLE_TIME)) { + mutex_lock(&sbi->gc_mutex); err = f2fs_gc(sbi, true, false, NULL_SEGNO); if (err == -ENODATA) break; - if (err && err != -EAGAIN) { - mutex_unlock(&sbi->gc_mutex); + if (err && err != -EAGAIN) return err; - } } - mutex_unlock(&sbi->gc_mutex); err = sync_filesystem(sbi->sb); if (err)