Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3525540imu; Mon, 7 Jan 2019 05:05:54 -0800 (PST) X-Google-Smtp-Source: ALg8bN7IpAO2lioxAN0ixkzFCNrO5s/Y960w4GzejETknKsP0uawg7xLDc7kAwrJ1GEe2cDIQ/VL X-Received: by 2002:a17:902:7882:: with SMTP id q2mr62888675pll.305.1546866354290; Mon, 07 Jan 2019 05:05:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546866354; cv=none; d=google.com; s=arc-20160816; b=ZlufavF2Oizu1wR1P6EsD2r3Y7JD4j7vgBaKK7Ktcc7OpCITFb47yVPmF4xTJkg3Zc g+60rUajbuVrz8C1hT0iwgii8BvXqe5yRgbxI8KgVeMyi9ncMtqPmch4rCsEhUzAyg40 fJS6hN61hJ5FuW7gvYD4w9s08nwP97e8vouOrT1KNRNAZUGPDN6BAmVBWTa1iOs0/bRp YGVG2uBLoYIUj8D7qCsO5XM9PxigjYvvKaaJfwqX2S9u4yJLkS1gKDfiDoo+LcaM2Ctb L6EC5y6DjwFJ4doPRAce0WniBcvk/as12dEuPhJ0+EY1yBcBF4JG8blfG6UK+eXYj4Io wX7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dJmsqjN0OPithjt28Kt/Am5Th7xrTlHO3T18LNG9NxQ=; b=wOeWn7M0jqLe8XeURl5M91r80oJha7dgOvjmTED2qS1RT2i7CnFiB66pONiFWVr1SU 6/7RDuCDeRXJrE8V1EB6dG3JD1wsGHf3dSLpL9rNfPnfkjqneztZAzHicDUVViNQqDFW 9HunhA4urF8B3k4xSljCMIHPmfnXHHSbMNgT18ji+7THyQrjDpt3UI0/2kkI7DiV9m2E v5Fc9aJ63hg3qCzj5tSK0BxJEG0v4ljH66nWt0yhsCCJin8m8zJT2k3qoc0Lf+hbP3Rm B7Gp0jlCxXzGPw+Iu1q5Op2fLlRhDeU5RcmTgUclE5BYQ+AHa9fRIgUAF2b44NMRQ81I hE6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eOh1W7t+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s19si60609584plp.151.2019.01.07.05.05.39; Mon, 07 Jan 2019 05:05:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eOh1W7t+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731048AbfAGNDj (ORCPT + 99 others); Mon, 7 Jan 2019 08:03:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:51106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731045AbfAGNDi (ORCPT ); Mon, 7 Jan 2019 08:03:38 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53007217D4; Mon, 7 Jan 2019 13:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866217; bh=KgbrA1LMCSh7xo1mRWV8KkE3zkWqG6GKmEkIZ/IW/C0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eOh1W7t+k/zkehSr+sPJXI1kcc5StXaIbjmQify2GD4JF0hxTvIPntKDuSjNxkt4l hLLZ+YwxcWHT8nBUrICiYySn+G4ogj1Eym2vHdm0sAczpjuxoCkBYPI9g5FHIPmKeT dEWiWsLAzRnYJgI7YuP1kp+9bFr2MjbrtNX1g3pM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mohan Kumar , Dara Ramesh , Sameer Pujar , Takashi Iwai Subject: [PATCH 4.14 048/101] ALSA: hda/tegra: clear pending irq handlers Date: Mon, 7 Jan 2019 13:32:36 +0100 Message-Id: <20190107105335.546076816@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.372621917@linuxfoundation.org> References: <20190107105330.372621917@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sameer Pujar commit 63d2a9ec310d8bcc955574220d4631aa55c1a80c upstream. Even after disabling interrupts on the module, it could be possible that irq handlers are still running. System hang is seen during suspend path. It was found that, there were pending writes on the HDA bus and clock was disabled by that time. Above mentioned issue is fixed by clearing any pending irq handlers before disabling clocks and returning from hda suspend. Suggested-by: Mohan Kumar Suggested-by: Dara Ramesh Signed-off-by: Sameer Pujar Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_tegra.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -249,10 +249,12 @@ static int hda_tegra_suspend(struct devi struct snd_card *card = dev_get_drvdata(dev); struct azx *chip = card->private_data; struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); + struct hdac_bus *bus = azx_bus(chip); snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); azx_stop_chip(chip); + synchronize_irq(bus->irq); azx_enter_link_reset(chip); hda_tegra_disable_clocks(hda);