Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3528469imu; Mon, 7 Jan 2019 05:08:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN6B0Zaq+e+ziPbwM9Cbect+1DQhZXMC7SsUtYu9J9AadaIHB74j06Pchl2WvXFjZjogyhA2 X-Received: by 2002:a62:5301:: with SMTP id h1mr8974595pfb.17.1546866509450; Mon, 07 Jan 2019 05:08:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546866509; cv=none; d=google.com; s=arc-20160816; b=noGNDke45wc+C8HiHqHUemt6UimhC99m5uPEev8usfi0+jFmm7G1otyOpXeMJC5Lsb pBNnk/QNXVra2TW3gLLPgL4Ad7pJJmMgIPxyvFRqHVRTOx6Xbqc7WicMaw8/G1qK++Xu L8tF8bjb1UoEYaRRAEQmYYm7s4qGkH2JOdkpOlXgtPyGf0yCIOo81ZN3Fw4T8mCmAKIk qup5HDuMuuJPcpheyAuiZvzfulUhs9+Ef0wPsFNdIkfu92TP7GJZxHKOPpPNiEehxTSA VZifPQqFO7MtjH3cgExiBMSA1ofqphja0IPiBsssOl2UcdFEKUKxsSx5C2jSofw9Xin8 Kw5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Zn6AyAEm3wWgUcC18KA8Ht/YGhIQzFAz8gXJhl1a6n8=; b=BI2VGgXY7fD+e15ui3BNGzmozrCeYwiGYjD6kxsLlfNfOr1thGvAJlCJ01BA4mZW/Z WTgMwxWbuuOho2uH5joQeH9gsVSk08NUKI7I8U+l4H/04mDziXFf6TngpfMHQv+9cZ7Y eYqLgX4F5rKy/yCSJXB/s2a7mKobeInmWaSdd9mldwKI7mqCjr6q2l0Vby/B+nLk/d6R kL1MZVLGFq6G8q/UyUSroRsO6lPOmF4K1hJvDL15+EJ9/5Yap2b+v5MksKDqujCyUuci QbcIMGzg44szhqu3k1IffzKPNhY1HDC59fC6ASjuvBO0QvMnIsunqFPTziryYuJI3SLO ta0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="r/5Mm3HO"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k5si13313317plt.111.2019.01.07.05.08.13; Mon, 07 Jan 2019 05:08:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="r/5Mm3HO"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731548AbfAGNGW (ORCPT + 99 others); Mon, 7 Jan 2019 08:06:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:53714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731115AbfAGNGT (ORCPT ); Mon, 7 Jan 2019 08:06:19 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 757C5217D4; Mon, 7 Jan 2019 13:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866379; bh=1m8KH8Rv/TvvcHKjlA5mSGSkIuDpymgpSrC8dJt+oeE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r/5Mm3HO3kHnJIKDBDOmEsLMMPzW2xlfh6875ltDVN6tfO7m1TC4TYbexQceDFShA 5Waq4n+5P+XLGzAmRz5X3rLGlhtUyNYjTh31M3wmTNqs8iZF+w7WvN16ezeCviiTJZ XRKdr16Utl+sFLq3Dc9bBaxucCN2dmlAWaNo8pDU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Willem de Bruijn , Alexander Aring , "David S. Miller" Subject: [PATCH 4.9 08/71] ieee802154: lowpan_header_create check must check daddr Date: Mon, 7 Jan 2019 13:32:37 +0100 Message-Id: <20190107105330.818014812@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.280153213@linuxfoundation.org> References: <20190107105330.280153213@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Willem de Bruijn [ Upstream commit 40c3ff6d5e0809505a067dd423c110c5658c478c ] Packet sockets may call dev_header_parse with NULL daddr. Make lowpan_header_ops.create fail. Fixes: 87a93e4eceb4 ("ieee802154: change needed headroom/tailroom") Signed-off-by: Willem de Bruijn Acked-by: Alexander Aring Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/6lowpan/tx.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ieee802154/6lowpan/tx.c +++ b/net/ieee802154/6lowpan/tx.c @@ -48,6 +48,9 @@ int lowpan_header_create(struct sk_buff const struct ipv6hdr *hdr = ipv6_hdr(skb); struct neighbour *n; + if (!daddr) + return -EINVAL; + /* TODO: * if this package isn't ipv6 one, where should it be routed? */