Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3529386imu; Mon, 7 Jan 2019 05:09:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN7At94yi+jWkPZ6/btH2THul8DRCMNrPl8zFghxYxWz/eqhYpkUTrtTSlGxNrStMLMCZunF X-Received: by 2002:a63:1b58:: with SMTP id b24mr10261133pgm.247.1546866559806; Mon, 07 Jan 2019 05:09:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546866559; cv=none; d=google.com; s=arc-20160816; b=QyWqZA+C1GcGSapovReVscls9HVzpCR+J76ZHCjnEbWpX6uT5Ja4RknxgUAC15hWdv X30eaDycPXdcV9fEIVFnKAh0unAcOAeGoyGrl9rGtSh3rALYcKzhioE2/0lv5h4oEjKW D8CJPQ4XmMQNEvGx+vHV0Il4W5IBVFX9AKNgMeQpJmCbuuDz9GYKARBwBlV1XjKfNYqI qMqbf2Fya/Ip/rObX01+Oeb/Xg4BO3iR5vaCwi20qu177TCzITUzTp/B+3XVxrFMP+88 /NDVumRMcZ1e1jnlhoVbcj3+DxWGKZBJvUGPxsB177v6b7BJk6dc5SyYJF/xRDzKITXR n+ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eyOgDwcIO8up+hVmU1wEvqdyDQp3xJNpkw3PIShCc08=; b=OTN5BzxxzL7eoyzemm3q8prv9G4B3izEg+OvRPFXibF2Kw6z+E0L5vO37Soc2k8nlA 0Yg41hQL1/dV9KMCT1dp9LuG672Q/uTgsT3WKLrsqK3vl+CEXy/C92hjA4W1b3Es5fcN Hb8tZcFMuha/oyScFNBq+2Fl2x+JYInHhJEfQF7j4Qf0oQmrm18LWWfTqFCNFjaNkA7K vKvXW8sTF6WVKxKFKW6rRxMzpQAeZLtyd2ZgO0HcsryouA6YMT2QSVDELD0THlsj66Dc obnaqFQox+jEOYmmNx6qM/i1tr2FHqlFX13GGmNRFq/4WoImrHmOzehJ8stEanoLMa1I H/VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MedF6ekX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7si18327058pgv.499.2019.01.07.05.09.04; Mon, 07 Jan 2019 05:09:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MedF6ekX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731309AbfAGNHQ (ORCPT + 99 others); Mon, 7 Jan 2019 08:07:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:54370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfAGNHO (ORCPT ); Mon, 7 Jan 2019 08:07:14 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18DED206BB; Mon, 7 Jan 2019 13:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866433; bh=4YINXhYo7YX/1lBQXGfWEnClP9n2PZJxhLZDW4pE0ZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MedF6ekXg7zoBT3asKjlagyqN0l5dA9n8D8ouNKNiCiEPPej7Yuk9HeX/2gaX8pZd kkNBGD+HhrRJogYkAmggGHeqHVWSXARzkupeBYBtwr6m8eyJszSzZvZv1FnZAmOZcK nST8jCmx2o92am9T4CyojNMt6UZtVsb3B9BVVvSM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mohan Kumar , Dara Ramesh , Sameer Pujar , Takashi Iwai Subject: [PATCH 4.9 36/71] ALSA: hda/tegra: clear pending irq handlers Date: Mon, 7 Jan 2019 13:33:05 +0100 Message-Id: <20190107105334.832592800@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.280153213@linuxfoundation.org> References: <20190107105330.280153213@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sameer Pujar commit 63d2a9ec310d8bcc955574220d4631aa55c1a80c upstream. Even after disabling interrupts on the module, it could be possible that irq handlers are still running. System hang is seen during suspend path. It was found that, there were pending writes on the HDA bus and clock was disabled by that time. Above mentioned issue is fixed by clearing any pending irq handlers before disabling clocks and returning from hda suspend. Suggested-by: Mohan Kumar Suggested-by: Dara Ramesh Signed-off-by: Sameer Pujar Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_tegra.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -249,10 +249,12 @@ static int hda_tegra_suspend(struct devi struct snd_card *card = dev_get_drvdata(dev); struct azx *chip = card->private_data; struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); + struct hdac_bus *bus = azx_bus(chip); snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); azx_stop_chip(chip); + synchronize_irq(bus->irq); azx_enter_link_reset(chip); hda_tegra_disable_clocks(hda);