Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3530157imu; Mon, 7 Jan 2019 05:09:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN49OIHIwJjU+hUq57A9sGQGfEuitdvlftAWEhaXqAEOryFsk/GyAaejxo+9XukjXOA6189p X-Received: by 2002:a63:ec13:: with SMTP id j19mr10789683pgh.6.1546866599735; Mon, 07 Jan 2019 05:09:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546866599; cv=none; d=google.com; s=arc-20160816; b=veJsV4bUOQxSmd9MjpHOLJ0M4h1wEtcSx1LlReBStb+abemPM2T+THG7uuocOeB4Jd bqdPwGMfq7giMW4ATe57ruVKBBkYwJJvbLoowIMv/Rrfp5qXGD6z/H95UEAmcHBnLHA1 Y+ywhkJ0YkDdC6UIGplIaTYGnHpmj2hVW8FQytqKhtZYjOQYi2Y6uO/OXfK63UvuoaAa kKUBvTnFR1HWiZJ2Zm6GVW15ZCN4cRkh5aWIH2gvc/NKoYgeczXql1gCcmSM76KgJokd h9n+SuLU4CYLXs3sdUmfrZOP7gfZKSQHCVSgAuw9zx54+KelUlYf7IR0bcMF1lIj0vRK kfpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WEt6ZySvmoUcR8QAppgHMeczWwNqdSEloHpDbAZDqZ8=; b=iDcTReUQUovSuulGlm2QR1xve4iDpx6/TP9/OEm9/SLLmw3QC8dzznRvaSyWWEuZMT gIMXxU6ChpJW6tP5vSlsYGHpbikDZEYbJmen+q5j2++3AE6qAFq0WvVpRcTyrzCszLwg E54NBYjJwLqM5y92miW/Bg7rFOK2vDlx3gbsQ3qp5hwSmF1Up9BfCivpn2afzTkoQy6o GErzF42n4/704tV4W9cQ++u+53CUnxY2DmxJM8MdrCx3rg+CB9ydcEP9zwG2clAqCvDo Mk9lEqziQyZx+toWXGHrqtuPA6PMDoCpNjDRzAXgC1bNpYrBdNml33DjQlmk8hJjBdtf 80yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hqtS2rSE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si61476040plh.261.2019.01.07.05.09.44; Mon, 07 Jan 2019 05:09:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hqtS2rSE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730967AbfAGNHt (ORCPT + 99 others); Mon, 7 Jan 2019 08:07:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:54830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727392AbfAGNHs (ORCPT ); Mon, 7 Jan 2019 08:07:48 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EF412147C; Mon, 7 Jan 2019 13:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866467; bh=p+2w8KfA2Nwtgk+Kf3FikIPzgjM1wfuF6D7XbRrjndQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hqtS2rSEBvoQtlUjV41XwmM7XhIT/oZn/tKG+yk6dxoSMmXQjqqV47rHwjfamjdpq zy7nETVqy7pwylBgSgwxIGUL+P+5H4l7IYtniUrk6PP8kfiE0HEzplPWXuFSkTEa5/ yS4doNgJ2AnKhuffDOV9jGrZdApQ6/EjlBI6AUUs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sebastian Sjoholm , Reinhard Speyerer , =?UTF-8?q?Bj=C3=B8rn=20Mork?= , "David S. Miller" Subject: [PATCH 4.9 41/71] qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID Date: Mon, 7 Jan 2019 13:33:10 +0100 Message-Id: <20190107105335.094283696@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.280153213@linuxfoundation.org> References: <20190107105330.280153213@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bjørn Mork commit 102cd909635612c0be784a519651954a7924c786 upstream. SIMCOM are reusing a single device ID for many (all of their?) different modems, based on different chipsets and firmwares. Newer Qualcomm chipset generations require setting DTR to wake the QMI function. The SIM7600E modem is using such a chipset, making it fail to work with this driver despite the device ID match. Fix by unconditionally enabling the SET_DTR quirk for all SIMCOM modems using this specific device ID. This is similar to what we already have done for another case of device IDs recycled over multiple chipset generations: 14cf4a771b30 ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201") Initial testing on an older SIM7100 modem shows no immediate side effects. Reported-by: Sebastian Sjoholm Cc: Reinhard Speyerer Signed-off-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -951,7 +951,7 @@ static const struct usb_device_id produc {QMI_FIXED_INTF(0x03f0, 0x4e1d, 8)}, /* HP lt4111 LTE/EV-DO/HSPA+ Gobi 4G Module */ {QMI_FIXED_INTF(0x03f0, 0x9d1d, 1)}, /* HP lt4120 Snapdragon X5 LTE */ {QMI_FIXED_INTF(0x22de, 0x9061, 3)}, /* WeTelecom WPD-600N */ - {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */ + {QMI_QUIRK_SET_DTR(0x1e0e, 0x9001, 5)}, /* SIMCom 7100E, 7230E, 7600E ++ */ {QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)}, /* Quectel EC25, EC20 R2.0 Mini PCIe */ {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */ {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */