Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3532678imu; Mon, 7 Jan 2019 05:12:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN6i5WtSf9i4ZpjtP2nGD5ucZu/4B+ze0SecSa4/dcs0dCzy2fUvvVnDnE0eiyu+ad1++ume X-Received: by 2002:a63:b649:: with SMTP id v9mr10926861pgt.436.1546866740647; Mon, 07 Jan 2019 05:12:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546866740; cv=none; d=google.com; s=arc-20160816; b=UKXfH6xdHLZU7knRSh0+IqaBdqmGXSZ2yeFXbiUjIUlgYej4Zn31p4qdO3YaGCJR+L e5TnD0yzPHeRzoH5/UAlW/SGe1ZOMqkZktyZE1gWLE6UHrb3PS+GbrcmfxKg3l3YMxyh Q6hNlLhTzs9jjVQNGF4byiwB2I9o9pF2Z3Osgz8YIpzeBAYyXb0H91LSIJAv/2R2jHH2 KLhEHenCM48lZGBE/cj38T67NpWKDkc3J93K9CIGFfP46VVP4sir2jZVaPTYoC4TQtrQ CkPPFmhNaA8yHx83PMSqSEfrSMXx6PGosBQ+RcI6MnPQ8boLd3hMmk+ICuCs1L0qBM+y V76A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pizG/7Eo3/pfnaIty8D7h6TXQC890FtGmunjph3y5zE=; b=llP3NwZhJo4yOLERwgQVT+SHSpuDQvSux6iqQbhoQp5b7Q0/dXaAIvkKmbpBL2fo2+ F6JRNUW6y0sms24M0/fpDtVPiMxfPGcgKpnmtxKf+UXJlwpF9m8KhqA+Evud5DTsF49r BcS0c3UnMyrzSU+5U/H75oIwyw776Acfp0yaVI9yXBRRluupogzSxsVivY1Hn+WjaVkO EdnKFUVWjRKeNl9xay/NX+r0ICyMdlkYtwKOFCStGhgvWHSgl8CrDsefyISRkoYll3wy vyP1Ktay/ujCPVGEGZwYm8MMNMTFhPTcxnFgZM+uXTvOkqNSXyyNd6QuCTTq8KPeCeXd 9OTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wxpnmdYc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y20si59778513plr.106.2019.01.07.05.12.05; Mon, 07 Jan 2019 05:12:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wxpnmdYc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731815AbfAGNKM (ORCPT + 99 others); Mon, 7 Jan 2019 08:10:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:56228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731931AbfAGNJP (ORCPT ); Mon, 7 Jan 2019 08:09:15 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A53F2089F; Mon, 7 Jan 2019 13:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866554; bh=lo7m50mnw1bqsD98CQ1RWzFWSOntplR77POEocNdLhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wxpnmdYcrJhrCA4Pz20AOes3SHdCLhsd6u67QwMIaQi3yEIZADnLWIL/6/iKeesbZ qiI+F3F9tPUfcVVFXCg/InYhqAv1mp5ddQ6V5XVOEaVHQfE9gkN0vrdERoUJMkfArn MZofF8NkZnFL2DiZM8ilC6Br1PbLPXYUtcuNxhIg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , syzbot+0cc8e3cc63ca373722c6@syzkaller.appspotmail.com, Mauro Carvalho Chehab Subject: [PATCH 4.9 62/71] media: vivid: free bitmap_cap when updating std/timings/etc. Date: Mon, 7 Jan 2019 13:33:31 +0100 Message-Id: <20190107105336.279402026@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.280153213@linuxfoundation.org> References: <20190107105330.280153213@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans Verkuil commit 560ccb75c2caa6b1039dec1a53cd2ef526f5bf03 upstream. When vivid_update_format_cap() is called it should free any overlay bitmap since the compose size will change. Signed-off-by: Hans Verkuil Reported-by: syzbot+0cc8e3cc63ca373722c6@syzkaller.appspotmail.com Cc: # for v3.18 and up Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/vivid/vivid-vid-cap.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/media/platform/vivid/vivid-vid-cap.c +++ b/drivers/media/platform/vivid/vivid-vid-cap.c @@ -452,6 +452,8 @@ void vivid_update_format_cap(struct vivi tpg_s_rgb_range(&dev->tpg, v4l2_ctrl_g_ctrl(dev->rgb_range_cap)); break; } + vfree(dev->bitmap_cap); + dev->bitmap_cap = NULL; vivid_update_quality(dev); tpg_reset_source(&dev->tpg, dev->src_rect.width, dev->src_rect.height, dev->field_cap); dev->crop_cap = dev->src_rect;