Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3538002imu; Mon, 7 Jan 2019 05:17:22 -0800 (PST) X-Google-Smtp-Source: ALg8bN7j36OeqlMrPkF06Ke6dOoA3xTjxqjXlYkKlNX32aQSnpHl+8nWpvEcCCmJ3XxOMFwp/EM+ X-Received: by 2002:a62:5301:: with SMTP id h1mr9007131pfb.17.1546867042038; Mon, 07 Jan 2019 05:17:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546867042; cv=none; d=google.com; s=arc-20160816; b=ESQK9zKJDzirz5mcw/A5NM7M+HqzSQz0+DR5KLG5xvbzzClbVYT3WdMo7Qs0pNgqoh 7HZ+ILRZuzATAOfJ6UcTtS4XdvwJ20ASCkcEAK+ZOBQDZosP4zwWIDuNCUP5HV7pan/e 2TZhG56EC3TJhDaAKsazNEY4xGXFZ9Hf6j8IAbNmE1TDHnE7kv691Qs2lK0sr2Xx3jwz YDBZxLFdL5ryr1eY6gcq80vKKStzgBRYDL69gjQrhPofbxfvBREhNSXUYi7iSip16Nbn 7JSpUlte+B62q0k+Yq6Ca806elrl6uuad2UerMexo4YecWPYr2NRt/UDNVGoHaFzI0DH xmXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TSB0OESx95NNlJIePAcjjllG8nFbzRHw+rzv9JNETPI=; b=0kE1jxLtLT/6Od8gamwPm+Z3f3VkZrmgI6Fzt63NEm5D3wZXIgea4tFF2qT6MVYb3U AX0mohtOKn5ZnxlVsseHyoPmcFgQDHe+xJA9xTxBRAs3PiIR63qmOA0sNWCKz34tgx+Z WSMCcvRWQ5nDjtroKo5TRCt4yObSs0d07XO6v+qH2s2gIls9YPDOyHR1m7ONvr9HQkJM m4SQkRIX/fVlAPGXhJ0aSIfiBbyNPo63BRH27LXYtAoXHP2Ig1wuOiv2NeKRVMl8/o8J 8DSEs9dJybKN3NfAHg96wKQtfSKWon7+UqgTtOqaV/Uzt1YDcxNc9cHIjl8NW+ugmlwH V+HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tm9WywgI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si7653320pfn.111.2019.01.07.05.17.06; Mon, 07 Jan 2019 05:17:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tm9WywgI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730733AbfAGNCG (ORCPT + 99 others); Mon, 7 Jan 2019 08:02:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:49478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730706AbfAGNCE (ORCPT ); Mon, 7 Jan 2019 08:02:04 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 444552089F; Mon, 7 Jan 2019 13:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866123; bh=fpIgt0hHU6M0Wccqr6631+ckn2qql5wD8ytJm1QxQfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tm9WywgIu6GhGCo18tnFUwYwyfT/6b5L8MhN+Tq+U55uhLOAPwOqigAHYjvPskA3X jeeeaXcWs+Vn5jswyXHoH274J3yZ6tXI+yFxmuZY18ibxwkkqZ16lKaGsGWthqP3PA cbZeTd9PD6aHJpycX4PX2HW52xzrVH68gb8K2tyo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sebastian Ott , Martin Schwidefsky Subject: [PATCH 4.14 054/101] s390/pci: fix sleeping in atomic during hotplug Date: Mon, 7 Jan 2019 13:32:42 +0100 Message-Id: <20190107105335.887669133@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.372621917@linuxfoundation.org> References: <20190107105330.372621917@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sebastian Ott commit 98dfd32620e970eb576ebce5ea39d905cb005e72 upstream. When triggered by pci hotplug (PEC 0x306) clp_get_state is called with spinlocks held resulting in the following warning: zpci: n/a: Event 0x306 reconfigured PCI function 0x0 BUG: sleeping function called from invalid context at mm/page_alloc.c:4324 in_atomic(): 1, irqs_disabled(): 0, pid: 98, name: kmcheck 2 locks held by kmcheck/98: Change the allocation to use GFP_ATOMIC. Cc: stable@vger.kernel.org # 4.13+ Signed-off-by: Sebastian Ott Signed-off-by: Martin Schwidefsky Signed-off-by: Greg Kroah-Hartman --- arch/s390/pci/pci_clp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/s390/pci/pci_clp.c +++ b/arch/s390/pci/pci_clp.c @@ -437,7 +437,7 @@ int clp_get_state(u32 fid, enum zpci_sta struct clp_state_data sd = {fid, ZPCI_FN_STATE_RESERVED}; int rc; - rrb = clp_alloc_block(GFP_KERNEL); + rrb = clp_alloc_block(GFP_ATOMIC); if (!rrb) return -ENOMEM;