Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency
 explicit
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Sinan Kaya <okaya@kernel.org>
Cc:     Linux-Next Mailing List <linux-next@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Message-ID: <7d6b9323-7760-944d-daa4-6fc663a32481@samsung.com>
Date:   Mon, 7 Jan 2019 15:17:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gkGaxgr+-CzsabqrfVFQFo_R+G3VEg3qF_sGWa6bT-Dg@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20190102181038.4418-1-okaya@kernel.org>
        <20190102181038.4418-3-okaya@kernel.org>
        <CAJZ5v0gkGaxgr+-CzsabqrfVFQFo_R+G3VEg3qF_sGWa6bT-Dg@mail.gmail.com>
        <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 01/07/2019 12:12 PM, Rafael J. Wysocki wrote:
> On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
>>
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly. PATA_ACPI is a PCI device driver but the PCI
>> dependency has not been explicitly called out.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>>  drivers/ata/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 4ca7a6b4eaae..8218db17ebdb 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>>
>>  config PATA_ACPI
>>         tristate "ACPI firmware driver for PATA"
>> -       depends on ATA_ACPI && ATA_BMDMA
>> +       depends on ATA_ACPI && ATA_BMDMA && PCI
>>         help
>>           This option enables an ACPI method driver which drives
>>           motherboard PATA controller interfaces through the ACPI
>> --
> 
> Any objections against this one from anyone?

Patch looks correct to me (pata_acpi is indeed a PCI driver):

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

but it is best to wait for Jens' ACK if you want to merge it
through ACPI tree..

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics