Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3700559imu; Mon, 7 Jan 2019 07:59:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN55JnsYiZw0/X6Sc5S88umNGMw5vn9v2D9xaKKryQndimvnT5EZ/MlI53kaZ45J14yv+hcq X-Received: by 2002:a17:902:887:: with SMTP id 7mr61402498pll.164.1546876791253; Mon, 07 Jan 2019 07:59:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546876791; cv=none; d=google.com; s=arc-20160816; b=JQV1wdU0ZTV0PCGydTQZuVcE2zV+hdNyiUXsnavOSutg/z8VPJhPFLjnI49pl8zZoq qCoEH0pfkJ/VB1Vohkz12ExfkkTn5gzSkrSrqpaXfQMMBh3ZzgOWNlu67T9h/nneNiRS FhYQ6cYSh1LPbafy6n8b+3Uz1dZcqTj00eu5ywVuRiHWqcQ6fw+5OxepToJgCDgXRxRz ZCDu3u0RIblBSFAoc1ub1fdh/IZpn8kjr0+I9NaMhD+feQLEOruPVfbjUe6VKc31ZnFJ ph9lCyLhmJZRL0z7oRR05ZQSOR+Q2c3ZAgs18TCH6idqb5AxiH8ygAcYWjQFf576pI49 i+FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=G20gidmol/GDcRNCXWFO7qFvtM2ESWXVxrqeE2x+P8A=; b=LyvETE32nN+2uppzAx5O+kM9WOAKZg2Q3Hua5SLJRG6vy4EMKwABBkUMbsOwQdn1PW JISqwNdm5GEVYLrDIa/O4kqP1ujLSxtIH0I5xth91JbByeXVNQEkPAvFr9+uu0LL6rKA PkT+qPwQstd1CuJs3JlAauXnXtuP/LuTPjYm5Qc/bpqfNjinnK6LaWl8tY5kIm39zfwW pBssEZooOqTszHmNPtZ1GOiVlk8KSrDZyZW8u2F5ILFwjisSaYCyBOegRFltErDs6VHH NPMev0g7c9H7KfSTkMY0BWx1egFLmcjKaaGEbzMOf/WRwrbYWIk4TY9VUAuZhcoU2/3N RxRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Qc2tlrRf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18si62744343pgb.491.2019.01.07.07.59.35; Mon, 07 Jan 2019 07:59:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Qc2tlrRf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728325AbfAGMmq (ORCPT + 99 others); Mon, 7 Jan 2019 07:42:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:58500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727788AbfAGMmp (ORCPT ); Mon, 7 Jan 2019 07:42:45 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9F7F20449; Mon, 7 Jan 2019 12:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864965; bh=bg376v0LRDhw5I2qRcUB/0X/dXugkt13CuajXMzau38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qc2tlrRfzT5LStA7qk59fwvy+QgibnupqqhqPuiM79EkQY0TN9b11sdpCZhEuHAb2 w7gYO1+qU33OYsY+BkZ8I+mdCamqIfI1dCU1c1Q7tyWDNn42WsGw829E/R8xRbdxV3 m1QqrnwDHjhj4C/M9iUk9C6Ia/oqLj5KUmiSaWdg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nava kishore Manne , Michal Simek Subject: [PATCH 4.20 109/145] serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly Date: Mon, 7 Jan 2019 13:32:26 +0100 Message-Id: <20190107104451.485760533@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nava kishore Manne commit 260683137ab5276113fc322fdbbc578024185fee upstream. This patch Correct the RX interrupt mask value to handle the RX interrupts properly. Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic") Signed-off-by: Nava kishore Manne Cc: stable Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -123,7 +123,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout #define CDNS_UART_IXR_RXTRIG 0x00000001 /* RX FIFO trigger interrupt */ #define CDNS_UART_IXR_RXFULL 0x00000004 /* RX FIFO full interrupt. */ #define CDNS_UART_IXR_RXEMPTY 0x00000002 /* RX FIFO empty interrupt. */ -#define CDNS_UART_IXR_MASK 0x00001FFF /* Valid bit mask */ +#define CDNS_UART_IXR_RXMASK 0x000021e7 /* Valid RX bit mask */ /* * Do not enable parity error interrupt for the following @@ -364,7 +364,7 @@ static irqreturn_t cdns_uart_isr(int irq cdns_uart_handle_tx(dev_id); isrstatus &= ~CDNS_UART_IXR_TXEMPTY; } - if (isrstatus & CDNS_UART_IXR_MASK) + if (isrstatus & CDNS_UART_IXR_RXMASK) cdns_uart_handle_rx(dev_id, isrstatus); spin_unlock(&port->lock);