Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 7 Jan 2019 17:19:06 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Ben Dooks <ben-linux@fluff.org>
Cc:     stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
        linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org,
        Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count
Message-ID: <20190107161906.GC2292@kroah.com>
References: <20181114171315.27549-1-ben-linux@fluff.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181114171315.27549-1-ben-linux@fluff.org>
User-Agent: Mutt/1.11.1 (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 14, 2018 at 05:13:15PM +0000, Ben Dooks wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> At least some systems benefit with less scheduling if the NAK count
> value is set higher than the default 4. For instance a Tegra3 with
> an SMSC9512 showed less interrupt load when this was changed to 14.
> 
> To allow the changing of this value, add a sysfs node to each of
> the controllers to allow run-time changing.

That's going to be a pain, why can you not just figure this out at
runtime and adjust it that way?

Also, you can't add a sysfs file and not also add a Documentation/API/
update :(

Can you fix this up to work without needing manual adjustments?

thanks,

greg k-h