Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3767587imu; Mon, 7 Jan 2019 09:05:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN7b+txjEKr/E6x1oIBscjIHion7TpGOJk/CLNkdd87UIdPtfsWBe7Xb9xo/jkVk2XfxxzZm X-Received: by 2002:a63:4c4e:: with SMTP id m14mr11708723pgl.173.1546880729875; Mon, 07 Jan 2019 09:05:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546880729; cv=none; d=google.com; s=arc-20160816; b=MPaLcMdtsqyADAMKbiwqfTqEbeHjwHKMlAGRtHVEYXdvv/O/KVZAoxErzpakf7u5Nf ucpauTvxgRAj/GwtVKkuPOryTsVZ1e/kK0hTFP81o7iM9RJlNeLMxUw+OjrIDt19P8EO 3hP2G6NSleUbmtvq1NCiHkFRupqLjU/EunO+Fz+PcUF+DiVzS3MzkpHDq8Ta8jrvY7V+ YMkqQLWC7L6saHzNCDdfHZU6Bj/ONUksOFNk08ZEdLlM2NSpSjylxpFTumuSClRx2Hhr T/BXKtzyXyuSGity0rmQA4yqE3qkW8cKIDp1MejpouzNh1mVy3O26Ln09cdsMP+Pp6Ac wWyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wJ4MjDnwC86MoIhHsIOAqYQGWAM3p3KPm6XnIE/zxiQ=; b=zveSamhzK3CvBCqQ/kQt7l1MOglGu9P7AWKqPAZ6FxFxK2jQ3o19rXvFRNhA4M0aec vALqEmv88jrmEtOzSSkz4N9ewRlivsCZlIQgO9SQ9fYxuxQZ9ZR9i+t0qxmDn3YBqW94 V/LIDcT0tqN99S8bXhBMS1rmvrsFLVK/kMtkLKDfz+dXyysKJ1l30YodcltYOUPYFg1s HBQ3iRY0407VkEPqdTtHPTg2K3SNDaY3w4TPUfLp+nJUBq4grUaQ6D8DZ/97529R+hmv sv5Sl72575oQOtvgKtknnJyrDW5Et+ADSA7Hg/wnyk6Ki07d9Xk1nC9Y+UehlGXgAAy6 1FjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KleAFnG5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r196si8470211pgr.311.2019.01.07.09.05.14; Mon, 07 Jan 2019 09:05:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KleAFnG5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfAGMeQ (ORCPT + 99 others); Mon, 7 Jan 2019 07:34:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:46190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727138AbfAGMeN (ORCPT ); Mon, 7 Jan 2019 07:34:13 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B368D21736; Mon, 7 Jan 2019 12:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864453; bh=dWuV6VvnvQHQjezLx5scxKZa6QqAgNfI4f9Fb6xUUxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KleAFnG5OPq97jQA+zGaBwdoAD/4CbinLURg50ZpESWz5vbU4ug8CtjdCIjPXgSrV VIisFf6WFIY7RzjV48ytIUGCW6xIF9E0yG/JzRFApvRqT5wlerxtm3rdS397fjs45p cECWWKpvWb5Lcibo3s/ahDymR5E2wh9/QmnJoMSU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Willem de Bruijn , Alexander Aring , "David S. Miller" Subject: [PATCH 4.20 008/145] ieee802154: lowpan_header_create check must check daddr Date: Mon, 7 Jan 2019 13:30:45 +0100 Message-Id: <20190107104438.392865197@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Willem de Bruijn [ Upstream commit 40c3ff6d5e0809505a067dd423c110c5658c478c ] Packet sockets may call dev_header_parse with NULL daddr. Make lowpan_header_ops.create fail. Fixes: 87a93e4eceb4 ("ieee802154: change needed headroom/tailroom") Signed-off-by: Willem de Bruijn Acked-by: Alexander Aring Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/6lowpan/tx.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ieee802154/6lowpan/tx.c +++ b/net/ieee802154/6lowpan/tx.c @@ -48,6 +48,9 @@ int lowpan_header_create(struct sk_buff const struct ipv6hdr *hdr = ipv6_hdr(skb); struct neighbour *n; + if (!daddr) + return -EINVAL; + /* TODO: * if this package isn't ipv6 one, where should it be routed? */