Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3819528imu; Mon, 7 Jan 2019 10:01:27 -0800 (PST) X-Google-Smtp-Source: ALg8bN5WRCM/KEB+idXbs2vSbrtEHcyCbU0nyjzhRxL0HMe0kN8Pa4WYJC68H1R0i3cjrbZEmb6P X-Received: by 2002:a17:902:468:: with SMTP id 95mr61385097ple.3.1546884087788; Mon, 07 Jan 2019 10:01:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546884087; cv=none; d=google.com; s=arc-20160816; b=Q9s3tYLpSwJCRRulZVHouSIhKLB/DpLIuWetzAtc7tM+YrJSeb6aao7oJZzKU+nnew kPiB8nEHuFQz3E8cM6ER5QP7C4NZZ1pF+jkrWiRDlXGEFWcmFl+il/NABRXv0mz1xCzM WBqCtkOPKncUhnViZ6q1RrvC2sZ70bCmFISYpzI240Yi1Rlcny1BCtKKEo5X8niPD0UB H9RPZdFtRU+D/MkVRZrhVwUSo71P5AinOvuJGHJqpkcMJIzzhNGhPtQW7zj3/Ir/cA/a YrYuYlXBIhSoBtttd5KwIhKA9bmYu+0yPlYRYWdbkl0sqsQjpxnD5LTtjLJFDKVQx/DK P4+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=LKkswnROirbpF/KGyCDLa7Ud5swPPWMPrQ+sPUYEaE0=; b=ulwUrEjHQBSMtgh8FE5AJJlCoNRGM9EfbBKUmZhQpOtqfr9Zw6aUyk4SrixOCLcvvL cMNIH05DKA2tPvabC7dZJATusP3RmbsNfADCT7iR9H1Hfcks9WWMcXjmsTE7j2M7u+OW ogdm0bFm9VT0cPopybry4ESMmE/dwXV4hO0CiQ6vYCwTGbeNnoYk4vFvLfs6qAV5/y96 BL1SkwxDZLWPTI3Y1KhMl51V3EFkRTaM48zbDFLV9byYAJPnl18C5cxg2S0I1Erh7Cfg YB2Nb8eifTd+EsdSSi5ukYZHLFPtK2o3aKvaaNGAMLGfylO3eqZYlRMb8Cp/TAs8ieYq wRmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7si4488185plo.12.2019.01.07.10.01.12; Mon, 07 Jan 2019 10:01:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727701AbfAGQqB (ORCPT + 99 others); Mon, 7 Jan 2019 11:46:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:58094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbfAGQqA (ORCPT ); Mon, 7 Jan 2019 11:46:00 -0500 Received: from localhost (unknown [144.121.20.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 20E6714C64640; Mon, 7 Jan 2019 08:45:59 -0800 (PST) Date: Mon, 07 Jan 2019 08:45:58 -0800 (PST) Message-Id: <20190107.084558.1009669820449792065.davem@davemloft.net> To: gustavo@embeddedor.com Cc: kjlu@umn.edu, jon.maloy@ericsson.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tipc: fix memory leak in tipc_nl_compat_publ_dump From: David Miller In-Reply-To: <20190105165223.GA3296@embeddedor> References: <20190105165223.GA3296@embeddedor> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Jan 2019 08:45:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Sat, 5 Jan 2019 10:52:23 -0600 > There is a memory leak in case genlmsg_put fails. > > Fix this by freeing *args* before return. > > Addresses-Coverity-ID: 1476406 ("Resource leak") > Fixes: 46273cf7e009 ("tipc: fix a missing check of genlmsg_put") > Signed-off-by: Gustavo A. R. Silva Applied, thank you.