Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190107121014.13499-1-ap420073@gmail.com> <20190107.072507.2123333109511407402.davem@davemloft.net>
In-Reply-To: <20190107.072507.2123333109511407402.davem@davemloft.net>
From:   Taehee Yoo <ap420073@gmail.com>
Date:   Tue, 8 Jan 2019 02:18:38 +0900
Message-ID: <CAMArcTVAWYBYhEwaWT0qZfo2=6p-OBqVvGqMHKj2wtkv8am-GA@mail.gmail.com>
Subject: Re: [PATCH net v3 1/4] umh: add exit routine for UMH process
To:     David Miller <davem@davemloft.net>
Cc:     Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org,
        Daniel Borkmann <daniel@iogearbox.net>, ast@kernel.org,
        mcgrof@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 8 Jan 2019 at 00:25, David Miller <davem@davemloft.net> wrote:
>
> From: Taehee Yoo <ap420073@gmail.com>
> Date: Mon,  7 Jan 2019 21:10:14 +0900
>
> > @@ -679,6 +688,29 @@ static int proc_cap_handler(struct ctl_table *table, int write,
> >       return 0;
> >  }
> >
> > +void exit_umh(struct task_struct *tsk)
> > +{
> > +     struct umh_info *info;
> > +     pid_t pid = tsk->pid;
> > +
> > +     if (!(tsk->flags & PF_UMH))
> > +             return;
>
> Let's really make this low cost.
>
> In linux/sched.h or similar:
>
> void __exit_umh(struct task_struct *tsk);
>
> static inline void exit_umh(struct task_struct *tsk)
> {
>         if (unlikely(tsk->flags & PF_UMH))
>                 __exit_umh(tsk);
> }
>
> Thank you.

Thanks a lot for the review!

I will send a v4 patch.