Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 7 Jan 2019 20:05:55 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     kernel list <linux-kernel@vger.kernel.org>, baolin.wang@linaro.org,
        linus.walleij@linaro.org, sebastian.reichel@collabora.com
Subject: 5.0-rc1 Open circuit voltage tables -- 3afb50d7125bc
Message-ID: <20190107190555.GA18865@amd>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="Qxx1br4bt0+wmkIi"
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Qxx1br4bt0+wmkIi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

Can we do something with that code?

First -- tables should not be necceessary. Formula for li-ion open
circuit voltage is well-known, and does not really depend on the
device -- only on the chemistry of battery.

state of charge =3D f( voltage, current, internal resistance )

(And yes, internal resistance depends on temperature and health of the
battery).

Second, even if we need tables, why is it doing multiple allocations?

info->ocv_temp[index]        =3D -EINVAL;

That's just wrong. Ocv_temp is temperature in celsius. Temperatures go
below zero.

								Pavel
--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--Qxx1br4bt0+wmkIi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlwzoxMACgkQMOfwapXb+vJWQwCffZliqg1CauJhr5G2AxH2XCZE
tUcAmQG/7RJ2xRgNIaKRERNwltVJnhHT
=Tkwq
-----END PGP SIGNATURE-----

--Qxx1br4bt0+wmkIi--