Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3918538imu; Mon, 7 Jan 2019 11:55:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN5S/ThCzrTs9QKX0H6q+KtqbD6MzOZ/XW/RCHvQqyFF+lDSUqEOQLlZF7gG1gMmdn46Iqqb X-Received: by 2002:a17:902:720c:: with SMTP id ba12mr62667042plb.79.1546890931674; Mon, 07 Jan 2019 11:55:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546890931; cv=none; d=google.com; s=arc-20160816; b=VvyJ43uT4j1zI2zbQf8GHK0H7DmVYsPyWkns7bpEY+nyB9gDSGKc85axkyqg1iX5Cx Sg17BOLO7oMHNbuUkPr6i0Nc7ulDfI0+C4GhOPcUYUSNwOTPYpXGijJvcJe7f4kCXcAX TelEfBrjCXwiMB91mDp8bH4khGBtJ0jVJqoXguOPZvfSCsr2IrKfv+xZ+SreNzLA5SEJ GIYAzpCS555mt0NMAe3W8QBTsJax7dx832RtNoFao8hEmJxIbTjvNOa2geWERf+CHOyo DxtPZlWfwM8VMqmz/znSWlZ6WPYr+IcLmDiy4zw8P0PUM8eTY8BaO8Z0TK2Yn532XSoA uF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=aFUOscSl1DRKobk9fr0ovhR5lgS5rgrBbyNjpV+wKHw=; b=dpNLBRTdopNXUkX5IVURCcdKAcJ8r53Dyqs97VSIrSxHVcfUKrrZrQA5wUSz2rRQ/N B3AIFUrmsJr7ONtFRnK9F/4KpsaeBYe2Jy17Tcq2t5gaof+ZYjkRDurDEI0LlHnifJxH oFNksBBNfGngxZF2lXoVMfzzxli6J2Mjjaz+QUnM6U8QyVpryLcV5ocm7ZV0QZFD3c9j DyfEaTIwHXbYsTVoHaIT/6kjcyoN6j6kr0ELiyFWgi/Q+ibr3HLEUu2vsMV5SJtlJevB lfakKFLluNm/kxQp4Zk7dWxovc/iG4bxe5JMp3do68+z2jxOLFU7DvUCVP/VDvCO2vYl 79yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u+zeCdSY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t12si60150942plr.311.2019.01.07.11.55.15; Mon, 07 Jan 2019 11:55:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u+zeCdSY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbfAGRb0 (ORCPT + 99 others); Mon, 7 Jan 2019 12:31:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:43822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726886AbfAGRbZ (ORCPT ); Mon, 7 Jan 2019 12:31:25 -0500 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BEDEA2183E; Mon, 7 Jan 2019 17:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546882284; bh=jEtJZK/3w4NvAKD/2Vid3GLq/LIc7NIhvT4e+SnT0Qg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u+zeCdSYHg5jbKckyD8h4iyrdqEkXAjWB5Vse5c4sYLWDExlcUCfKLFgdpo34wY82 Rq94PyDQUkVn1BEuQtZUapRoHQcWfILctvvkxdBST0QBgIeZlzF5rdfL7iYTf/sbt+ oYUXzJDcW13TZ6gJDuXwS9R2GxRgaBTfWhI9cot8= Received: by mail-qt1-f172.google.com with SMTP id l12so1309064qtf.8; Mon, 07 Jan 2019 09:31:24 -0800 (PST) X-Gm-Message-State: AJcUukcmG7EekSdC8xg5vmI4KR5p5EWgx3UgANdUqjnsuGgd+2ilotUN NC/CYBajgQhKuV3TqT46+/9QlWjD1LGOkU7fxA== X-Received: by 2002:a0c:e2ca:: with SMTP id t10mr63129488qvl.77.1546882283974; Mon, 07 Jan 2019 09:31:23 -0800 (PST) MIME-Version: 1.0 References: <20181207125844.18775-1-malat@debian.org> In-Reply-To: From: Rob Herring Date: Mon, 7 Jan 2019 11:31:12 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks To: Mathieu Malaterre Cc: Bartlomiej Zolnierkiewicz , "# v4 . 11" , dri-devel , Linux Fbdev development list , LKML , Elimar Riesebieter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 2, 2019 at 2:03 PM Mathieu Malaterre wrote: > > Bartlomiej, > > Do you need an Acked-by from Rob, or can you take it in the next round > of fixes for v4.20 ? Sorry, I missed this. > > Just to repeat myself, previous code would call > offb_init_palette_hacks(), which in turn would do: > > if (dp && !strncmp(name, "ATY,Rage128", 11)) { > > with name=NULL. I prefer to fix this properly using node name helper in offb_init_palette_hacks(). I'll send a patch shortly. Rob