Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Jan 2019 01:08:54 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        YueHaibing <yuehaibing@huawei.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Jann Horn <jannh@google.com>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] kernel/sys.c: Fix UNAME26 for 5.0
Message-ID: <20190108000854.GD3987@latitude>
References: <20190107180306.16602-1-j.neuschaefer@gmx.net>
 <CAHk-=wgAH7QZrAyzaTV1-6MecaSdVkiowSZEM7qwa0L2oegpLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oJ71EGRlYNjSvfq7"
Content-Disposition: inline
In-Reply-To: <CAHk-=wgAH7QZrAyzaTV1-6MecaSdVkiowSZEM7qwa0L2oegpLA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--oJ71EGRlYNjSvfq7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 07, 2019 at 10:10:31AM -0800, Linus Torvalds wrote:
> On Mon, Jan 7, 2019 at 10:03 AM Jonathan Neusch=C3=A4fer
> <j.neuschaefer@gmx.net> wrote:
> >
> > UNAME26 is a mechanism to report Linux's version as 2.6.x, for
> > compatibility with old/broken software. Because of the way it is
> > implemented, it needs to be adjusted to handle version 5.0.
>=20
> Do we actually need this?

I don't run any such old software, so I don't have a strong opinion
here; I just sent this patch because I knew UNAME26 version strings
would jump back without it.

> I'd rather let it bitrot, and just let it return random versions. It
> will just start again at 2.4.60, won't it?

Correct.
(Well, it's 2.6, not 2.4, but yes)

> Anybody who uses UNAME26 for a 5.x kernel might as well think it's
> still 4.x. The user space is so old that it can't possibly care about
> differences between 4.x and 5.x, can it?
>=20
> The only thing that matters is that it shows "2.4.<largeenough>",
> which it will do regardless.

Good point, I guess that's a valid appraoch.


Jonathan Neusch=C3=A4fer

--oJ71EGRlYNjSvfq7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAlwz6g4ACgkQCDBEmo7z
X9tnPQ/8DrchH8ol/s3F9fk2ak3Wvu68ACF13dJTptlAzZJSdRkaFNGBKGoqkhVA
UvYhmsu3JFFxGlcarrtqV6OS41ReLVrmtTvscCfrKtXZKlQ5AW2vXnEpJpVUTKMA
3wJk9S59sYVQ04IArWtgOa6Eaoupul9G0/ferm8cgb78ZtxpFszlMPvXmuDpauNh
R1gfkL2qDXyOjVhgnobpFma8I+RBhJWIQrKJgGr1oZ+8qhtE9hBwRgiHobNmQ4YH
H9h22ZIDG4tOAsjSTXhvTsMkl/Tozql1UAypSZ4/dLsP8hAjobidDhk9Cg9qKjYI
8MdHY8dzlXzFfRuRyJU4JxNLHy4O5n5PsWZN/I8dJdhMepqsg13+elENxTXWoxct
z8/VSeeB0lG+Ipg7CarXVSbLxU9909JCkQk09bu9SjIPoc2tiQnjjVMmXlZzH/F8
tcZYAfov24e4Ciop6I1aAhHOcqhQzPb4SG5HQ6fwlM2R2QfL4gtJ+jhv0KZRJJlB
I/K4AbOwpuSmmWHX9TUwUApjyCCqi6saav9afdKgWEfi2Cxo2wqjkRpVjTimBWcO
wyrKg9lGTTXfroV5KEMmDWwQn69L08UlSus+B3k9mUXrnTB86oHPMK230VHivNLC
Yobf7EVHYqlvOfMhsu45wXh5wzx3TtX19zttpR908gE0O4dUJPE=
=XkwY
-----END PGP SIGNATURE-----

--oJ71EGRlYNjSvfq7--