Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4126648imu; Mon, 7 Jan 2019 16:17:56 -0800 (PST) X-Google-Smtp-Source: ALg8bN77jKg3DmhlppUs+j7Z5x8MFChM5PjrIefQR6wp7B+4091tUe2uJL+STTzJsnWdzanvgr+9 X-Received: by 2002:a62:c101:: with SMTP id i1mr4914899pfg.80.1546906676255; Mon, 07 Jan 2019 16:17:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546906676; cv=none; d=google.com; s=arc-20160816; b=ZhAtr+H2VMy38Lx/l72I9/u1uamjmM57ll58gN99VI61VR0E3VINb57avl3E7A06xy 5P965ghTsUs0D1B3D4YxTr+Xu6R9cI3aNaV/reDwMVy6B951jRyADnao0kCcqBUpGXG9 gFjf1maWgI2e/qoVKI0pDp+tZ5CBQx8IhMiUYsBr5ZXL52UFt3JVvo0z011dThu/+kga 3A2l93fJwMyEBgdwGoSg+cUgpV9PJvQwWFTQK++BOVv9d/ZexWlbHli0VvL6KQOfzxzr o0JdzsFIfQoEfkf3Z2lxaw7JzMImgxSmspkeclD+dzz2EfIfR/F652PpuuUsz8TVdnQ8 fiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=TTWla1Udb838KKvwY2IlqIYuhvp/Sfkv79T2e3fMOIk=; b=Os0z8QUfQOMT/6KGH9SDoHni1LvYrTvqj+8DyD/HX7v7Xj/BiyV+i9Wwjq+Fv8BL3H Xd7V/zdYTiLECuqP7dN/BGNEOvdAYWP/Be4cnfd9OxlipJWyZlfywgoMHd1MSyJXEtW6 gOjaDokRaFwHWmgeLfVNihoY5YRRy+ooUqOkyOVctVwKCFNdRuuPDPW3bFqNo7rXXxhP BTHHKNP9mDFRoARChswk5UD7xIzBxD26S/Y7LwqoU7HCTf1Vl7HzjUOWem3a0gGbV2g7 0DqDEgG/OCQyNqgSoOE0TMr6iYsQDr5ykGf2mE7PnZ2T5OqpLv1LpDWVVm6yu1MbPPpE Y+Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=AaQzgaPD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b15si21724646plm.431.2019.01.07.16.17.40; Mon, 07 Jan 2019 16:17:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=AaQzgaPD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbfAHAMp (ORCPT + 99 others); Mon, 7 Jan 2019 19:12:45 -0500 Received: from ozlabs.org ([203.11.71.1]:57891 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbfAHAMp (ORCPT ); Mon, 7 Jan 2019 19:12:45 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43YXlF3ftgz9sCr; Tue, 8 Jan 2019 11:12:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1546906362; bh=cMTDZtCI1H59M+pn3p1TP7P3b+Xt+dG4315tizUTpmc=; h=Date:From:To:Cc:Subject:From; b=AaQzgaPDGftjeSkQnSAERObD5uAQOk6yAyvZ71I+UzvLVeVdDtJQG4FserEAX7u7U pWXm2uwvA8l0aCDlj4wcr7ZNOHZF3qTAo1eZYU8lvt9eStPIpaeS3nB5VnZEOKTGjB xIFjHgv2PPLaKV/wx2WlrJ0ksrCS1z03li+kPOFwnsMX2E3czx4IQXrzBIcgbrCOya LwiVdwiSn7jtLzqyYwUyNdqBDq8udsmARW+O6qFcne2dUHBdhOCrVzZa8RtyKRdn5z vA5nSli7/ZYVdXvyrm37UtWDYsIP2B3IizJvKqR4VuYd/CS5ieFJT3pYCl+ifAPElq BPGwzE/urkAwQ== Date: Tue, 8 Jan 2019 11:12:41 +1100 From: Stephen Rothwell To: Daniel Vetter , Intel Graphics , DRI Cc: Linux Next Mailing List , Linux Kernel Mailing List , Rob Clark , Boris Brezillon , Nicholas Kazlauskas , Alex Deucher Subject: linux-next: build failure after merge of the drm-misc tree Message-ID: <20190108111230.2dd3abd9@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_mode_config_init': drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1695:30: error: passing argument 1 of 'drm_atomic_private_obj_init' from incompatible pointer type [-Werror=incompatible-pointer-types] drm_atomic_private_obj_init(&adev->dm.atomic_obj, ^~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_dp_mst_helper.h:27, from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:34: include/drm/drm_atomic.h:437:53: note: expected 'struct drm_device *' but argument is of type 'struct drm_private_obj *' void drm_atomic_private_obj_init(struct drm_device *dev, ~~~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1696:9: error: passing argument 2 of 'drm_atomic_private_obj_init' from incompatible pointer type [-Werror=incompatible-pointer-types] &state->base, ^~~~~~~~~~~~ In file included from include/drm/drm_dp_mst_helper.h:27, from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:34: include/drm/drm_atomic.h:438:30: note: expected 'struct drm_private_obj *' but argument is of type 'struct drm_private_state *' struct drm_private_obj *obj, ~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1697:9: error: passing argument 3 of 'drm_atomic_private_obj_init' from incompatible pointer type [-Werror=incompatible-pointer-types] &dm_atomic_state_funcs); ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_dp_mst_helper.h:27, from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:34: include/drm/drm_atomic.h:439:32: note: expected 'struct drm_private_state *' but argument is of type 'struct drm_private_state_funcs *' struct drm_private_state *state, ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1695:2: error: too few arguments to function 'drm_atomic_private_obj_init' drm_atomic_private_obj_init(&adev->dm.atomic_obj, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_dp_mst_helper.h:27, from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:34: include/drm/drm_atomic.h:437:6: note: declared here void drm_atomic_private_obj_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Caused by commit b962a12050a3 ("drm/atomic: integrate modeset lock with private objects") interacting with commit eb3dc8978596 ("drm/amd/display: Use private obj helpers for dm_atomic_state") from Linus' tree (merged during the merge window). Its not obvious how to fix this up, so I have used the drm-misc tree from next-20190107 for today. -- Cheers, Stephen Rothwell