Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4222139imu; Mon, 7 Jan 2019 18:28:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN5blWFhqoKm1xDJMExzh4vKcalTiK+KBF7HwBpGM9bmibm6J4876jtGihSSTZ0JSD7ZekE5 X-Received: by 2002:a17:902:8484:: with SMTP id c4mr62040844plo.59.1546914511965; Mon, 07 Jan 2019 18:28:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546914511; cv=none; d=google.com; s=arc-20160816; b=biQYLihjZe2LIp8zBiwyr5G5BGzC8ixoP/KB1tYHpgmFa8jg+Xoz1TnpurG8fp+cIX E+1PT3BUKnjgIBb/Mmh9BAKea+dPqqbCimW+muczVZIi5vUGcGs59dLwpA8YBTS28Pyw /KwlDXFko0wuMQBuJ3/DSrCNFoWojmKF8bocoEhnvusQnDuSTak/11401FmesadkEY6P C3zTG6IClVty7j8uGlNYoRMMnfUhKP/U5Zh/ngXRtZhNhWnthL7lwB/wZL1d8dB7K2UT Sb4M6cuv+LcrYa0EOMj0GdNcm41ranX7kwp4XN09dnU6+DVwrDyltYL+2OLVHeqhTIFm xfCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SX90UBekJzYVENNVAPAaUTEPQCERodGyNvZx1/BDC+U=; b=PCUGG7LA3JkZmv8qZY/9jvdz+HxtkC2Zn/cpksRu6Yd1lsnRt0Vf2oTKr1YR/v6+Nf TvzxqtrUqDPgEPgOp2ewXe2syP8AA30vobhJh/VmBfzoj13yNGHTeEDOsXQeSxkSaGSv BPZTxDb5z1Ng848liEGlC7FOFln8oDI4GFLR7WjKAU3azSi5bmw+4QPm1EV2pM1lG9li mGI7/BM9Jx4C2llbx0pRCRskRDvv6NryqA0pS4cCeD63CzE7OrGYxD3Psp/Df7Gi5t+o LkWVjYZT0sOPV1J3LjjXecnz3u1GiHrHfE4nZOr+9vOg52dJ+1Ulc3uMjvFYsMYN/p6Y X+wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=E0Zan9aj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h75si6658354pfj.257.2019.01.07.18.28.16; Mon, 07 Jan 2019 18:28:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=E0Zan9aj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727383AbfAHC1E (ORCPT + 99 others); Mon, 7 Jan 2019 21:27:04 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37678 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727030AbfAHC1E (ORCPT ); Mon, 7 Jan 2019 21:27:04 -0500 Received: by mail-wr1-f68.google.com with SMTP id s12so2502554wrt.4 for ; Mon, 07 Jan 2019 18:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SX90UBekJzYVENNVAPAaUTEPQCERodGyNvZx1/BDC+U=; b=E0Zan9ajdLXT4vUEP5eubEmai085wD7gRQzUudGKCTlnrL6ssC1r7HVWYfcW1c2FP6 efH2TJem9QkYs5UOth9n1hhD3rBwqyq6As9qi21ulMJgwG3RyLdGnxJzg2tUUFyd98m7 biLl9dHvnlDLCUmofCdW4SL+8qX3Om/GOQHnfrXVeCNTSGt8PuZByviwo0XUb3eKimIO AAOYt+RO/GPDVzOwqeZA5Rh0HHxBjCoQ/U3WZE1Vzud9SZeEII7nJhcvMhWKbGqgAAfo WRSKIUZ09G5GkkG85xaglEVTcNuq7QkNzWzjIx/Y1HOkrur28huZxvH/I7d+m3h94DH2 EAag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SX90UBekJzYVENNVAPAaUTEPQCERodGyNvZx1/BDC+U=; b=KLUs9psMxRbdNBeQ8c6HK1mGRbmYmyYxFP7hJl/92MwYpFbBbkuB39ztNPV2Gv9/4w utmnP0eiwscy9qDVyvVDJp0wbjy/KpzEDWsdn6X0X20RZR6Ea9cl8lX9BrJYSTtNgjTU N/mLZsEwbkpb8HJrBYRK7K2hMy9dxO73RHh6Zxb6Hws6ewWcaSMq8esY2WrnuaOfcqBD dDm7HNEtD16m6uVdYNjbKqwD3A84VbwVcbHPNJT3nfpj4soVKhfL0GxCS1t11YzhJPE5 E3sAyEtsIGXwQaYsCi00jSaSTYmfWvTUymzF2+S4TXFxY10rYuA9o5MWsRn5r0OivIvT 1mzw== X-Gm-Message-State: AJcUukdq8KUSKeRS3jfHGMzfKQZIQcJS+GafOQzrtGbXOlLs3IkUN2AB zgYNnsyEr0xs1w1cLnWKPdA= X-Received: by 2002:adf:d243:: with SMTP id o3mr55778954wri.66.1546914421791; Mon, 07 Jan 2019 18:27:01 -0800 (PST) Received: from flashbox ([2a01:4f8:10b:24a5::2]) by smtp.gmail.com with ESMTPSA id v6sm42832544wro.57.2019.01.07.18.27.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Jan 2019 18:27:01 -0800 (PST) Date: Mon, 7 Jan 2019 19:26:59 -0700 From: Nathan Chancellor To: Arnd Bergmann Cc: Andrew Morton , Andrey Ryabinin , Anders Roxell , Ard Biesheuvel , Will Deacon , Mark Rutland , Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , Stephen Rothwell , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] kasan: fix kasan_check_read/write definitions Message-ID: <20190108022659.GA13470@flashbox> References: <20181211133453.2835077-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181211133453.2835077-1-arnd@arndb.de> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 02:34:35PM +0100, Arnd Bergmann wrote: > Building little-endian allmodconfig kernels on arm64 started failing > with the generated atomic.h implementation, since we now try to call > kasan helpers from the EFI stub: > > aarch64-linux-gnu-ld: drivers/firmware/efi/libstub/arm-stub.stub.o: in function `atomic_set': > include/generated/atomic-instrumented.h:44: undefined reference to `__efistub_kasan_check_write' > > I suspect that we get similar problems in other files that explicitly > disable KASAN for some reason but call atomic_t based helper functions. > > We can fix this by checking the predefined __SANITIZE_ADDRESS__ macro > that the compiler sets instead of checking CONFIG_KASAN, but this in turn > requires a small hack in mm/kasan/common.c so we do see the extern > declaration there instead of the inline function. > > Fixes: b1864b828644 ("locking/atomics: build atomic headers as required") > Reported-by: Anders Roxell > Signed-off-by: Arnd Bergmann > --- > include/linux/kasan-checks.h | 2 +- > mm/kasan/common.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kasan-checks.h b/include/linux/kasan-checks.h > index d314150658a4..a61dc075e2ce 100644 > --- a/include/linux/kasan-checks.h > +++ b/include/linux/kasan-checks.h > @@ -2,7 +2,7 @@ > #ifndef _LINUX_KASAN_CHECKS_H > #define _LINUX_KASAN_CHECKS_H > > -#ifdef CONFIG_KASAN > +#if defined(__SANITIZE_ADDRESS__) || defined(__KASAN_INTERNAL) > void kasan_check_read(const volatile void *p, unsigned int size); > void kasan_check_write(const volatile void *p, unsigned int size); > #else > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 03d5d1374ca7..51a7932c33a3 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -14,6 +14,8 @@ > * > */ > > +#define __KASAN_INTERNAL > + > #include > #include > #include > -- > 2.20.0 > Hi all, Was there any other movement on this patch? I am noticing this fail as well and I have applied this patch in the meantime; it would be nice for it to be merged so I could drop it from my stack. Thanks, Nathan