Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4318089imu; Mon, 7 Jan 2019 20:53:01 -0800 (PST) X-Google-Smtp-Source: ALg8bN6tubs0hkEA8Oq+EcLOwCiEeDOUn4rIH5lI0/v03B5wYtopH4/dO11AHqVR0Pcb6wIQMKmq X-Received: by 2002:a62:7792:: with SMTP id s140mr318196pfc.26.1546923181146; Mon, 07 Jan 2019 20:53:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546923181; cv=none; d=google.com; s=arc-20160816; b=lliXwleFb2Mw3b+eyHr5eh4JR9D4JblGE0rlCwACQ7b5lBbK4MdkRtpdG3vEPl8R3o ZDBpdDEinJFIVcHdZFXw9/eTSzBJ3WDgfRpm9sEMoechDUmy2TxVwiZArrPOtso4o3Oz mig6T40F1k0IHvttNecGqclztQ4MEaFXl9YXA61btrVn5mqUg9Zda8ZDFNVGfawwLjmj 16ew1jH9qaWLX+mhRPC3A0m2y+b3zBDV0hDRlcJAk+37Aqpml5tNADBy35F2wZgXKCD8 Mp/qKXV4k7jf6qyL5IGrviTwCvMn8C3H34drhvbQCdJOpEnYh1GKgJ7J3O77j5Lz0Q+D qX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WzLE1kl1n8qfTCuciv1x7YgTzmk4xHvqyK6zizNAsLQ=; b=P7KHNTYcnrgrgL5jz1LNdBV+UAsu5Qjdl2Uv2kQ7JxS5QQN5cqlKsJQDiEOKsKiIap WjJKe3BTCMp6kZ+R4opVHnaQkWoXYUnfJlY+tzyR7iO03wlrofTO78RQ9OuEU6b8NSzA CITNGWE7wWkhXOMRAOp/aOM+nhPaI/PUP+0KG4iPK8oPzurTurAH4UXPLGIX4jHpZHLk x0JkpRB6XSm59n41Vauxk+StjnyttbJrqDcYlzwrA8kghY4SQQm2jxurDgbBb5cHxME4 +MFg70XYUYeqUjarBrS8JUKzaTeVlJzIDH2HCfbHvkn/9PCBBSi74Psc0lbGho0WPH7A JqKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=CGcrzugW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b24si18570256pgg.288.2019.01.07.20.52.45; Mon, 07 Jan 2019 20:53:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=CGcrzugW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727678AbfAHEve (ORCPT + 99 others); Mon, 7 Jan 2019 23:51:34 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:37310 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbfAHEvc (ORCPT ); Mon, 7 Jan 2019 23:51:32 -0500 Received: by mail-io1-f66.google.com with SMTP id g8so2197580iok.4 for ; Mon, 07 Jan 2019 20:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WzLE1kl1n8qfTCuciv1x7YgTzmk4xHvqyK6zizNAsLQ=; b=CGcrzugWjzCZw5wd+yyC/qHn/OxPNIIQOiOTLkty4jiVxNtNQ/28SXXw4A8++QUkoL k0CuF1r7v7NqlMBT6FdTAxNCkHKOZ1RvyWPqHU4QG0gnVd13dEfA/GnK0LnmmyWg29I4 a1BQpJAhruVWnN7bKqTly7Y1ac3/sx305nUFhx1POGxUWdqXSyRcS0QFCosJHXucsydC +cYHGH0AvvI8lklaXlpaPd1vHRZA1dZ75stD8RsknCTJHkFfISX4GTgLvSHSdRVKinzI FAsgm1D5fMjy9NvkoZMoC2Qv2vigf1vi8jY+fkVcBGQ7USC4JuSEiPnK5QYvWvSgo4Az sTXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WzLE1kl1n8qfTCuciv1x7YgTzmk4xHvqyK6zizNAsLQ=; b=TZLAR7EPcLVkdhneTl3rq1tYWwANUKta78Zfq2fIFxYGd5cPfV+TXWEtsaILpOG1Tb aidYcULUWbtdsmp+cD+ooTtnjv5nJp44DMA0bC4ga2mt6Xd3i4M+69dtaqh+zpurZxoP K4Moaa1dbqn+wc8UDGz+a4aCTyoTbTMN/rb5W2ZbrB1I8VSizgBFTG5iG4XcAk7jdaSo Gyz73DMPEfS2gs++4/LyaxOKAWOZicNm4/mE9nK9GB+IObcNq/qvCfJ/t06geuUSQPn7 E888ndI+kJVxQH7rM7rjKwd29KesqgDi7IbAgdlhDBQkuTu6ay0B1TNTpq+HfDN+4oH4 sVGw== X-Gm-Message-State: AJcUukdZ8H5oFmLU64qxXyOP0R0gszhXFIlqrWYWinJK6NIqBD0mxRQ9 U4Z8/RQY8pRNkDxZMdnwkD0xk8G2xNXpFhiFA5iqiA== X-Received: by 2002:a6b:fa0e:: with SMTP id p14mr118472ioh.271.1546923091512; Mon, 07 Jan 2019 20:51:31 -0800 (PST) MIME-Version: 1.0 References: <20181211133453.2835077-1-arnd@arndb.de> <20190108022659.GA13470@flashbox> In-Reply-To: <20190108022659.GA13470@flashbox> From: Dmitry Vyukov Date: Tue, 8 Jan 2019 05:51:20 +0100 Message-ID: Subject: Re: [PATCH] kasan: fix kasan_check_read/write definitions To: Alexander Potapenko Cc: Arnd Bergmann , Andrew Morton , Andrey Ryabinin , Anders Roxell , Ard Biesheuvel , Will Deacon , Mark Rutland , Andrey Konovalov , Stephen Rothwell , kasan-dev , LKML , Linux-MM , Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 8, 2019 at 3:27 AM Nathan Chancellor wrote: > > On Tue, Dec 11, 2018 at 02:34:35PM +0100, Arnd Bergmann wrote: > > Building little-endian allmodconfig kernels on arm64 started failing > > with the generated atomic.h implementation, since we now try to call > > kasan helpers from the EFI stub: > > > > aarch64-linux-gnu-ld: drivers/firmware/efi/libstub/arm-stub.stub.o: in function `atomic_set': > > include/generated/atomic-instrumented.h:44: undefined reference to `__efistub_kasan_check_write' > > > > I suspect that we get similar problems in other files that explicitly > > disable KASAN for some reason but call atomic_t based helper functions. > > > > We can fix this by checking the predefined __SANITIZE_ADDRESS__ macro > > that the compiler sets instead of checking CONFIG_KASAN, but this in turn > > requires a small hack in mm/kasan/common.c so we do see the extern > > declaration there instead of the inline function. > > > > Fixes: b1864b828644 ("locking/atomics: build atomic headers as required") > > Reported-by: Anders Roxell > > Signed-off-by: Arnd Bergmann > > --- > > include/linux/kasan-checks.h | 2 +- > > mm/kasan/common.c | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/kasan-checks.h b/include/linux/kasan-checks.h > > index d314150658a4..a61dc075e2ce 100644 > > --- a/include/linux/kasan-checks.h > > +++ b/include/linux/kasan-checks.h > > @@ -2,7 +2,7 @@ > > #ifndef _LINUX_KASAN_CHECKS_H > > #define _LINUX_KASAN_CHECKS_H > > > > -#ifdef CONFIG_KASAN > > +#if defined(__SANITIZE_ADDRESS__) || defined(__KASAN_INTERNAL) > > void kasan_check_read(const volatile void *p, unsigned int size); > > void kasan_check_write(const volatile void *p, unsigned int size); > > #else > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index 03d5d1374ca7..51a7932c33a3 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -14,6 +14,8 @@ > > * > > */ > > > > +#define __KASAN_INTERNAL > > + > > #include > > #include > > #include > > -- > > 2.20.0 > > > > Hi all, > > Was there any other movement on this patch? I am noticing this fail as > well and I have applied this patch in the meantime; it would be nice for > it to be merged so I could drop it from my stack. Alexander, ping, you wanted to double-check re KMSAN asm instrumentation and then decide on a common approach for KASAN and KMSAN.