Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265584AbUA0RjM (ORCPT ); Tue, 27 Jan 2004 12:39:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265369AbUA0RjM (ORCPT ); Tue, 27 Jan 2004 12:39:12 -0500 Received: from palrel13.hp.com ([156.153.255.238]:64135 "EHLO palrel13.hp.com") by vger.kernel.org with ESMTP id S263891AbUA0RjH (ORCPT ); Tue, 27 Jan 2004 12:39:07 -0500 From: David Mosberger MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16406.41527.446833.703928@napali.hpl.hp.com> Date: Tue, 27 Jan 2004 09:39:03 -0800 To: Jes Sorensen Cc: davidm@hpl.hp.com, Paul Mackerras , Andrew Morton , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 In-Reply-To: References: <20040120090004.48995f2a.akpm@osdl.org> <16401.57298.175645.749468@napali.hpl.hp.com> <16402.19894.686335.695215@cargo.ozlabs.ibm.com> <16405.41953.344071.456754@napali.hpl.hp.com> X-Mailer: VM 7.17 under Emacs 21.3.1 Reply-To: davidm@hpl.hp.com X-URL: http://www.hpl.hp.com/personal/David_Mosberger/ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 793 Lines: 23 >>>>> On 27 Jan 2004 03:11:03 -0500, Jes Sorensen said: >>>>> "David" == David Mosberger writes: Jes> David, Jes> I am just nitpicking here, but wouldn't it be better to stick Jes> to the convention of all upper case defines for the #ifdef Jes> check? Yeah, it is nitpicking! ;-) Jes> Maybe use something like? #define ARCH_EXTABLE_COMPARE_ENTRIES Jes> ia64_extable_compare_entries I'd rather have ARCH_HAS_EXTABLE_COMPARE_ENTRIES or something like that, in that case. --david - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/