Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 8 Jan 2019 13:13:35 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     rkir@google.com
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: add a
 driver
Message-ID: <20190108121335.GA3349@kroah.com>
References: <20190107185039.190919-1-rkir@google.com>
 <20190107185039.190919-3-rkir@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190107185039.190919-3-rkir@google.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 07, 2019 at 10:50:39AM -0800, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
> 
> The Goldfish sync driver is designed to provide a interface
> between the underlying host's sync device and the kernel's
> fence sync framework.
> 
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> Changes in v2:
>  - Added a missing include (mod_devicetable.h).
>  - Put in one batch with goldfish_address_space.c to avoid merge comflicts.

You have a number of WARN_ON() calls in here that are not needed, please
remove.

Also, why is this driver needed at all?  Why can't you use the "normal"
drm sync api interface?  Why write a custom ioctl driver just for this
one kernel interface?

thanks,

greg k-h