Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4742527imu; Tue, 8 Jan 2019 05:38:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN7HPceGeCcyJ+jk+cYLN7WqGfx6QsXdgAwnte/a/5PJnHKMOm80ZcQiLl4SfAMf0tFiM/xG X-Received: by 2002:a62:2b8b:: with SMTP id r133mr1783801pfr.246.1546954709014; Tue, 08 Jan 2019 05:38:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546954708; cv=none; d=google.com; s=arc-20160816; b=aELN6nab5qwtTNAlURPNkNTCsY4a6sKbCh4hYkMwRGgDH4cXWLTBjU3LIjSQp6RyDO IeJXLcgjp+WnHo+dhqowzxCh+KQtz0z/oMiAUvhi+HTqpk+2jQx7ZCfex8frVWPlExGE VyEPw9Wjnw2tc9k80fB1drfTO+c2g4yhFWFS8i+Pri/CNpDK8QEwU92h8sU2SU6rh3qo Y2c/MubpK11oO5BMpo8MHw/djm/q8aNr7Xz9ZNOm1UP/m541G1zi+fCeom5Odldo5AkU lXoI8k7myidds7Bt590pF2KUWNrWnTv9qzi8f+yVwKYdrcjwQC4NuEwqPmejBj6ZljaH l/Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=GILjKP7OqNfbuANgp3bXB5P2aPPVdL7FiqYBhMaOv/M=; b=A8vSc+Cf9nrXV0ZB+/njkSV2G9s9Xoba1JQQx7dhvqoBm5hPqQDnxppD2UfcgBE63e 6pUtfE13XrKMzfay2obJceH5svhZ23YGftHpkY14cN/HKTiRyYcaufYAGQn8EgBeaSK7 pGk4zYCMtjqqD2Hmo1xmZQZLCzm0PGvxX99xH12LEZfrahpzvaT3U32uu5vc6kDY39dy s7+I9tz/qP+9CTqyU+TtRcZwGhLo2nGJ0BiRu4vf/RVcMKaR0cz2BQ8NAjs0GZgCswY8 SAhLi/b9mMEsPv7h+8CrbCTQSvDh7bb9YyGMnLUStha9RkmwzMLie9slecHSE2sMdRH5 fZsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="o/CcaRh/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11si18189379plo.184.2019.01.08.05.38.13; Tue, 08 Jan 2019 05:38:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="o/CcaRh/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbfAHNZG (ORCPT + 99 others); Tue, 8 Jan 2019 08:25:06 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42218 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbfAHNZG (ORCPT ); Tue, 8 Jan 2019 08:25:06 -0500 Received: by mail-pl1-f195.google.com with SMTP id y1so1897715plp.9 for ; Tue, 08 Jan 2019 05:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GILjKP7OqNfbuANgp3bXB5P2aPPVdL7FiqYBhMaOv/M=; b=o/CcaRh/eJ9APh2Gp6Jhm7ZJ6UZr6LzX8YQimsq8jt10aXyQAAvsFKBCAveK7v033B pvX9biqwj6mBlJZZm0xQAPXmcBqQbAuUm1NBJPpWaGo/LOfRKZFFbpcwNW6AkpbWK5rT 0SXvMGOmqeD7kQLTqZQ+8j1mjTw+dRrTdYFZFyVhagucXzgEJH436i/aqFgIx/dzavsS 2EpahowloqEVVkeiXOmNLnc9XeoQ6/8lX8hvHe43VYRcj364SILt8yOmMwNZN6sVqNkx Ig5dsgWiVhNm/NI2QHc1+JMmxHqsccdbEIeb+uPH2jT9H+aGc1iAvocyCAZu4FSfDfBN SO+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GILjKP7OqNfbuANgp3bXB5P2aPPVdL7FiqYBhMaOv/M=; b=JDZE2pMXKfAH6mmvD9YSh9CAJEPApR/qH2k5leS6gqnUhPMOvXZteaPpJQ02MwCT4F 6WvmVN/tKf+NMYqGn3woRW2a3zVVwPm6+MFkIoMrJSpfE5n9uqeWyOPuZjDeYhIDY4+p pt0Atjy6WhMejGmZmBAKJ/gfHY5Ibjz8snXh8BXbqnf2vxHZGB0ZlcHFB2txMuPdkIrh r1RXsol73lqAlyuljeEMdufiAcumjcfIbQ89BjI2iCGAmmIFWb5LQgptxOmJvKzfHK7/ 476wRyTOyiT4fm7lDTNcoQ/ILoZzY37g57cICKBm+QUS4sPhOJA0WEABZTqOe0PoXy3w Ej6A== X-Gm-Message-State: AJcUukeyDi1476qSuufdgUGtWv6OoK2nPSS2cBPQ+HzGacWtTb0aDmZh RlaYN/X1x9FPxqmyU367Nj4= X-Received: by 2002:a17:902:e012:: with SMTP id ca18mr1777954plb.218.1546953905843; Tue, 08 Jan 2019 05:25:05 -0800 (PST) Received: from localhost.localdomain ([220.94.163.22]) by smtp.gmail.com with ESMTPSA id l64sm87224371pge.73.2019.01.08.05.25.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Jan 2019 05:25:04 -0800 (PST) From: Sidong Yang To: Gao Xiang Cc: Sidong Yang , Chao Yu , Greg Kroah-Hartman , linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: erofs: Add identifier for function definition arguments Date: Tue, 8 Jan 2019 13:24:54 +0000 Message-Id: <20190108132454.20513-1-realwakka@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add identifier for function definition arguments in xattr_iter_handlers, this change clears the checkpatch.pl issue and make code more explicit. Signed-off-by: Sidong Yang --- drivers/staging/erofs/xattr.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c index 80dca6a4adbe..59bc5641c4e7 100644 --- a/drivers/staging/erofs/xattr.c +++ b/drivers/staging/erofs/xattr.c @@ -117,10 +117,12 @@ static int init_inode_xattrs(struct inode *inode) * and need to be handled */ struct xattr_iter_handlers { - int (*entry)(struct xattr_iter *, struct erofs_xattr_entry *); - int (*name)(struct xattr_iter *, unsigned int, char *, unsigned int); - int (*alloc_buffer)(struct xattr_iter *, unsigned int); - void (*value)(struct xattr_iter *, unsigned int, char *, unsigned int); + int (*entry)(struct xattr_iter *_it, struct erofs_xattr_entry *entry); + int (*name)(struct xattr_iter *_it, unsigned int processed, char *buf, + unsigned int len); + int (*alloc_buffer)(struct xattr_iter *_it, unsigned int value_sz); + void (*value)(struct xattr_iter *_it, unsigned int processed, char *buf, + unsigned int len); }; static inline int xattr_iter_fixup(struct xattr_iter *it) -- 2.17.1