Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4924870imu; Tue, 8 Jan 2019 08:32:22 -0800 (PST) X-Google-Smtp-Source: ALg8bN44x4INOD01Tl8blC4vw7DKeIB3yb4Gox0l74av4vPatvFXqEXIPxjtwac1p/MMVjBVRdP7 X-Received: by 2002:a63:ca02:: with SMTP id n2mr2105044pgi.187.1546965142536; Tue, 08 Jan 2019 08:32:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546965142; cv=none; d=google.com; s=arc-20160816; b=FgsVDlTX+tv3DfPQUTxKKFrkLKur64V2+5wq/giqjVK03196AOU/eH8GmiYBViEnXF wJLAVITryGEzCuNsNiocFNkAjq7hQjqzUq+siVRwP0XB8A0pohJ+xmu+H9R/WCemKKmC 7ky1wC5TJv3iB7ET1cjBr84wNbw9jZioIQpbBfoYmua+rs0ETnJO24ko3LaFutEeG8Hr lQCmRZWQkv7FfZyE5Kvnpuh0Ig3Gfx1a4ZSBfIubEUlIARI/ajom9g/CB7qEMaFfKzSh Ms4ThGQ0vS5RXNAqUPqlyYfIRJtlKUfx//U85DhRi6RpRTnfzqW/9dfwXAA1uVnQ4IVA Xp2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=CKgLnrW+E/F9fmcHxmHfb7VnWDtS/BVJUi9WCDjXH5E=; b=DdsOILClspHhGAEiuHv3ic+fHhqq6pSMX9dcdtPGvf1SIN0W78nGBYoZnnAzTkFQNk Cf4nMFTjlV4IobXQ2xNAQjirpjzVsSu0aORWSpHXY7FfqG+7BlV5IdZv6RwLahnGw250 lG+pRZP4GiATK7fDaeuD0qbllLaE9jhlTduqUt7WHNXuHQCkDfDkenY9flSXkLy1UflU 773SvSaGaYgwMlB55fTEIoG/E1Eqfxe9d+5A+CMPthcl1rZKpPieFykeT5jJMOmVDm+G YI0E3exzIwbyt5EBOMj2F+uLw+dQfAp/XvyDul5IWqGereG3xorRSdMD9sXCDcdHBqqx uGWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=NKJKBGfN; dkim=pass header.i=@codeaurora.org header.s=default header.b=SDVp1Y69; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si72225236pfd.236.2019.01.08.08.32.05; Tue, 08 Jan 2019 08:32:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=NKJKBGfN; dkim=pass header.i=@codeaurora.org header.s=default header.b=SDVp1Y69; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729266AbfAHQa6 (ORCPT + 99 others); Tue, 8 Jan 2019 11:30:58 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35376 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728238AbfAHQa6 (ORCPT ); Tue, 8 Jan 2019 11:30:58 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B801A60C87; Tue, 8 Jan 2019 16:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1546965057; bh=9bK1G9kbhxt5A4pFHkUy6wvbmBdIkmh57PlBlSH297c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NKJKBGfNTxZMTB+BtOAdinzoQnqc/8EHwJR7TwuqW5FXDtrmhgV3X1pu28KW6a5mm 7U8uzRLzxzG8jNGvRsB608WTEKY5V4iMwvz9C93uwYxT1LKn6JvKDvDAlYh+K0Q0ts GpcYeA7QqBt5XjIlbafpmTv3/qoNFn+L0NwnDE2U= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 144696079B; Tue, 8 Jan 2019 16:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1546965055; bh=9bK1G9kbhxt5A4pFHkUy6wvbmBdIkmh57PlBlSH297c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SDVp1Y69TbW+7WdGa7d+ltostzrVeAb60PR7/dJtxU82l6Yo4Fq8W9KDJx6zK/CFN HpYPEib3o/R8VwtkS/CkcE1mmziQ4TtegOIEcxodzBpsMQ/bwKHLXgvZEa68bIh0ut lVuf9k3yQTTdE3ndVLNWnt96v5uK5fyFxmqGljTo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 144696079B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Julia Lawall Cc: Solomon Peachy , kernel-janitors@vger.kernel.org, "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/20] cw1200: drop useless LIST_HEAD References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> <1545555435-24576-21-git-send-email-Julia.Lawall@lip6.fr> Date: Tue, 08 Jan 2019 18:30:49 +0200 In-Reply-To: <1545555435-24576-21-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Sun, 23 Dec 2018 09:57:15 +0100") Message-ID: <87bm4rru12.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall writes: > Drop LIST_HEAD where the variable it declares has never > been used. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // > > Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") > Signed-off-by: Julia Lawall > > --- > Successfully 0-day tested on 151 configurations. I assume I can take this to wireless-drivers-next. If you are planning to push this via some other tree please let me know. -- Kalle Valo