Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5062240imu; Tue, 8 Jan 2019 10:49:38 -0800 (PST) X-Google-Smtp-Source: ALg8bN7oA3/HUaG8NrNvntT5WBJCN+ur3hjz14ogMVPJSPrYpXtzJ2+R8Dr8cFEB1EAKFPkcxuVN X-Received: by 2002:a62:53c5:: with SMTP id h188mr2837039pfb.190.1546973378428; Tue, 08 Jan 2019 10:49:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546973378; cv=none; d=google.com; s=arc-20160816; b=D4WD98NUmilhs2p++EMtq6dpqVZsi9FDt2TGKoFUZOhL8qDVICya/kNyN5EOA3zgeT UXh70hWbwf9vSDoA4ViXzd568aWTGog0X8cO0babbgaqULFekP1WjVQGePCx5YSQhO05 8kFwuHF7HA3Ifbo2WJv/D95TBEyd3+6+SIM84VZyEAVaLjAYY4/cWX4cIwe4wPM4Lbh8 nYf6uy+FLTy/9ji5mwYEMG8+Br109jYMN+a2duQeTxjyypNKLk7MSZaRq2mk5PMEIF8H hFGmsk/ADDbHqSjUcbKRwWJV3hPfZaOZ4/GNuXDPIjmSlvCiMUMDnWDtdx9R1wCQDk6M DWyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=F0OUNDCjvIFUedJX3vHAv2902Kf63rHT2fdTGePIlVE=; b=pjKzKKUNdWgOQf4tX5IHMcooOM2eBHCAnN6JJXxXMx6qa7wqDDMAkLj9JqUmIDzeNN KHXIzfGo1ksk8VEsDlZz+GUusasT4+JcbxlWHwalJbJ9ne1ll56SurcynWSYjUsfAgkh xs4ZcIWFN5KaOjQhydHBf366tQdCmkcuDqflCUEMhTt7YkoL3joEuWgexOoXE6PwBEQJ r0mXVlK+OCx1zI+Ikb6INXddhTLNj7IC4OKQIk9QRU1ROT+jkbsXhZbay/vEMvbXDwhG OCMxde9mwYZNpg0AvGGUlvd2MtOrKhlpREl9SkewW1DJKhScaTJBy5sqQdNUYJok4DuC Emnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g31si50113287pld.358.2019.01.08.10.49.22; Tue, 08 Jan 2019 10:49:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728744AbfAHRUF (ORCPT + 99 others); Tue, 8 Jan 2019 12:20:05 -0500 Received: from mga05.intel.com ([192.55.52.43]:1194 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728398AbfAHRUD (ORCPT ); Tue, 8 Jan 2019 12:20:03 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 09:20:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,455,1539673200"; d="scan'208";a="132736565" Received: from mint-dev.iind.intel.com ([10.223.25.164]) by fmsmga002.fm.intel.com with ESMTP; 08 Jan 2019 09:20:00 -0800 From: Ramalingam C To: intel-gfx-trybot@lists.freedesktop.org Cc: Ramalingam C , Greg Kroah-Hartman , Kate Stewart , Thomas Gleixner , Philippe Ombredanne , linux-kernel@vger.kernel.org Subject: [PATCH v10 03/40] component: alloc component_match without any comp to match Date: Tue, 8 Jan 2019 22:44:29 +0530 Message-Id: <1546967706-15195-3-git-send-email-ramalingam.c@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1546967706-15195-1-git-send-email-ramalingam.c@intel.com> References: <1546967706-15195-1-git-send-email-ramalingam.c@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If all the components associated to a component master is not added to the component framework due to the HW capability or Kconfig selection, component_match will be NULL at component_master_add_with_match(). To avoid this, component_match_alloc() is added to the framework, to allcoate the struct component_match with zero associated components. Hence component master can be added with a component_match with zero associated components. This helps the component master bind call to get triggered, even if no component is registered for that particular master. This is meant for big PCI device drivers where small/optional features are external components, and based on usecases different combination of components are build as entire driver. In such PCI device driver Load, if we use the component master for waiting for few components(features) availability, only if they are supported by the underlying HW, then we need to allocate memory for component_match using the API introduced in this change before the call to component_master_add_with_match. Signed-off-by: Ramalingam C Suggested-by: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Kate Stewart Cc: Thomas Gleixner Cc: Philippe Ombredanne Cc: linux-kernel@vger.kernel.org Reviewed-by: Daniel Vetter Acked-by: Greg Kroah-Hartman --- drivers/base/component.c | 30 ++++++++++++++++++++++++++++++ include/linux/component.h | 2 ++ 2 files changed, 32 insertions(+) diff --git a/drivers/base/component.c b/drivers/base/component.c index e8d676fad0c9..0ab36b2255ea 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -312,6 +312,36 @@ static int component_match_realloc(struct device *dev, } /* + * Allocate the match without any component_match_array elements. + * + * This function is useful when the component master might end up + * registering itself without any matching components. + */ +void component_match_alloc(struct device *master, + struct component_match **matchptr) +{ + struct component_match *match = *matchptr; + + if (IS_ERR(match)) + return; + + if (match) + return; + + match = devres_alloc(devm_component_match_release, + sizeof(*match), GFP_KERNEL); + if (!match) { + *matchptr = ERR_PTR(-ENOMEM); + return; + } + + devres_add(master, match); + + *matchptr = match; +} +EXPORT_SYMBOL(component_match_alloc); + +/* * Add a component to be matched, with a release function. * * The match array is first created or extended if necessary. diff --git a/include/linux/component.h b/include/linux/component.h index e71fbbbc74e2..3f6b420a58f8 100644 --- a/include/linux/component.h +++ b/include/linux/component.h @@ -37,6 +37,8 @@ void component_match_add_release(struct device *master, struct component_match **matchptr, void (*release)(struct device *, void *), int (*compare)(struct device *, void *), void *compare_data); +void component_match_alloc(struct device *master, + struct component_match **matchptr); static inline void component_match_add(struct device *master, struct component_match **matchptr, -- 2.7.4