Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1546915794.git.tsu.yubo@gmail.com> <8c73ad4b2b29bda53f2dfb6624b8b7984b52e307.1546915794.git.tsu.yubo@gmail.com>
 <CAJZ5v0iiPKNVz3SE1oumOUDPGTrCHd5-hEoe6O=SsqSKD39XNg@mail.gmail.com> <20190108125355.yc7ryyl34s2me4z7@yubo-2>
In-Reply-To: <20190108125355.yc7ryyl34s2me4z7@yubo-2>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 8 Jan 2019 19:12:45 +0100
Message-ID: <CAJZ5v0gntQsDjqs17g=165if4g9rYR3C2vzKkXnjzt6b87kE+A@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] kobject: use pr_warn to replace printk
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>, yuzibode@126.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 8, 2019 at 1:54 PM YU Bo <tsu.yubo@gmail.com> wrote:
>
> Hi,
> On Tue, Jan 08, 2019 at 10:39:57AM +0100, Rafael J. Wysocki wrote:
> >On Tue, Jan 8, 2019 at 4:11 AM Bo YU <tsu.yubo@gmail.com> wrote:
> >>
> >> This is a fix to replace printk with pr_warn
> >
> >You call it a "fix", but what exactly is wrong with the code as is?
> Is there any differentions between pr_* and printk?
> If they were the same with functionial, i think it  would be better
> to use pr_* to replace printk.There are two lines code with printk only
> and others are pr_* in kobject_uevent.c.
> In fact,as you know, the code is fine.I just want to keep consistency with
> looks like

OK, so please don't call it a "fix" as doing so suggests a functional
defect in the current code that is addressed by your patch which is
not the case.

You can write something like

"Replace printk() with pr_warn() in kobject_synth_uevent() to make it
consistent with the other code in kobject_uevent.c."

in the changelog which would be clear enough IMO.