Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5114511imu; Tue, 8 Jan 2019 11:46:54 -0800 (PST) X-Google-Smtp-Source: ALg8bN58aRlNA9J1dIHhBOMutX207aV2rMmxw4fbEGFUiygynXfHkGCppqLDacWN/7sQkSbragje X-Received: by 2002:a17:902:33c1:: with SMTP id b59mr3048172plc.220.1546976814599; Tue, 08 Jan 2019 11:46:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546976814; cv=none; d=google.com; s=arc-20160816; b=ngAKoPB08iqVRkv0fpJ/2zsfQVp1pCxRhh0mOPQv7MWo7idmlf0BwDbIhahF8DdMGf 9pMYkXcTUm5F/UUp6XDB5dKjgB1uM/lwy2Gq5KVFEaDNcOWRUwuWC5Xrur4lNh6BIU0c GCSy7oKApkVidDYFzWVZIaSn3Dpuk6Ty25UQ8fWU2GS5zCaX2YU2fwQ4SVt6M7xUpLov PhMoI2fYg37O+1sdWLddqf62xQsV+X7wlVVotMTiJvuyGEk4brEfcng7R6CyDUPuukaP KD9IClACGGFk9ajIiZfmI0JlnwwWKjVrYc7aKJXiHH9Pz3mKoynj1+sWHZ8KOFOuS4zO liWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kAcpKixWtHGEPESaLO1jfQIkKD8g3uluyYQMkCQxYT4=; b=Vt05X6uUKXRDPIv5kHQhHJtn3XOEtSUdJwgNfK09IE0msgRRMkMG8NfARaif+7aZ0n 9ir7anlKwS5nm0qErE3SiB1ODU0slaV3qxWUOYg4UZyJ+to09CZR8TNrwjwekMauKj4A JU9RUthYO30saE27nSHut8BrkeTTzVBVaE4mAl+csjwhpxWx+uLDEl1EwCMD4piig8mr cmjOSFLPpcMQNMguOruxqZ87SspsMxANH0Gudxzn+sWQWxMmOV/gnWcOJNgRDi2bbS3w Lolu4DmZazQHBip9vXWjfEtxkL0yjht0J66OlacDm79pOO+s6Xm/CgwtXuJVtbQuzSqD ZEcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WNbbiha+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 85si66360587pfc.145.2019.01.08.11.46.39; Tue, 08 Jan 2019 11:46:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WNbbiha+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732691AbfAHTn5 (ORCPT + 99 others); Tue, 8 Jan 2019 14:43:57 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:49870 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731283AbfAHTnt (ORCPT ); Tue, 8 Jan 2019 14:43:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kAcpKixWtHGEPESaLO1jfQIkKD8g3uluyYQMkCQxYT4=; b=WNbbiha+WCx7XuYFvQE2Fllvi Kzjd9oeL8X5tW8rp99y2IebzMzDBEOUuO8MqSWMMB5HH+0Skn1AW1Gvtke+y5igEFO/nx5m/A1nZx 6N7k5G34MqMrOZH3/en6Wl2mGRWZj0c4whPgLtGjdMo/kkUVQpZ0oXFO3enTgdtV6OhyKbIQIMP1K LA8ILDWYV7SkrrgTvR9z5kSnQfYQ4rpYWg8Iizm+hFNNDqsbFmnghWaOSR7XB5PJG8b2s4yv7scT6 VCswykby70e1+zmLsIOrkDH+/4OGqTM8XYpDRrbc6LrbJKmx8Rcnv3TuWMFbFLQLUx9k0EkRTKypX NK0W1jyNQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggxHu-0005w5-1o; Tue, 08 Jan 2019 19:43:46 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 22EA520280199; Tue, 8 Jan 2019 20:43:43 +0100 (CET) Date: Tue, 8 Jan 2019 20:43:43 +0100 From: Peter Zijlstra To: Song Liu Cc: lkml , Netdev , Arnaldo Carvalho de Melo , Alexei Starovoitov , Daniel Borkmann , Kernel Team Subject: Re: [PATCH v5 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL Message-ID: <20190108194343.GE1900@hirez.programming.kicks-ass.net> References: <20181220182904.4193196-1-songliubraving@fb.com> <20181220182904.4193196-2-songliubraving@fb.com> <20190108183127.GB30894@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 08, 2019 at 06:56:19PM +0000, Song Liu wrote: > I don't think we need u64 length. 32 bit should be more than enough. > > How about we revise it as: Yep, works. Although I would not introduce types we're not yet generating. We can add those easily enough when needed.