Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5125894imu; Tue, 8 Jan 2019 12:00:58 -0800 (PST) X-Google-Smtp-Source: ALg8bN4fkINC7o/7AD7JVQ+d6n820zaHyjKdsqJ9neEnoBp8fVmqW9FJrPZAetoVVC4plDL8jtgX X-Received: by 2002:a63:9041:: with SMTP id a62mr2650495pge.163.1546977658882; Tue, 08 Jan 2019 12:00:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546977658; cv=none; d=google.com; s=arc-20160816; b=vOvYZ3LMa0RSUEXaa/+SvzmgUd4kzkHy9MSrr7JjFT0tZHxzBKMLcSpQ92h2uaiEZp C0J1hMSGKyLdrI7eJ0108GoBXNxP1Gx1RlBobbTPBOzS+iom9BRX0j/Gw2+tQTZH2Hk5 l5AiUR1Ddyx7z5jJd0l/UT7v9ekwG23zjK5ScLNQ/Q2mRrGLwxAMnsgHfCgft5PTkNaF 4TwhmdjxTfky/LxYXa9+bcCuyP1T8fTUPCS9b7aYXILJOXrOSp7hcUDbaAZtql7ZqKk+ 1VMP2mu0imBUKHII9blDLAwudOZRoQvJ/yh9KgueekMr97+nMCuOuZj9DBsGPa05uMye t5yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RSa6aMclAwHoaCBMzFB+Dbro+nCP1vCCGtA0BG4Nykc=; b=mEis1kp09eDNm7b4GdwnoB6rq3Rp6U5opQSRodf14GQg8+6IWxFhZCZnqBYU+wkvcJ CGf1UqbYQOU3rkbgDejTwqZE9rRliZz7zjZs7Mf4zOP90tfyZRCIDXO4KDzyKFSKFcaN uF5eInSrtyqEV16fWEhyqNTexfoEN7mihLu0rQUEuwnv+5rhGrMgEqiKfDcHOT1P9MrN wYCTxxrCCsmi5AgtOkmSh5b3/gDmE8UG1Itv3Hrm4Q1bBE2HR8qyJXOVCyX8TZdHGi0n O4B3pATe5DM+iKeSpRK2dducYwUniuNx+BqO5uwh06jT9i5bvam+dMcc+sYuds1wxyLM hvJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GupwEUhs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d33si43935949pla.359.2019.01.08.12.00.43; Tue, 08 Jan 2019 12:00:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GupwEUhs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730397AbfAHT33 (ORCPT + 99 others); Tue, 8 Jan 2019 14:29:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:36820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730378AbfAHT3Z (ORCPT ); Tue, 8 Jan 2019 14:29:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C543F20827; Tue, 8 Jan 2019 19:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546975764; bh=pm3JeSy63KrIYje1en2A7ML/QHGUlpAe4QFSXnLBIgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GupwEUhs40T/I5yYLaOtCguR5InP2IwJRhu9Mx+tj622pdxrbojrdSvNc7NNu8wSg dpzCh7YR2p0ZLhncqLI3MerbiVU5pzlJqb5ubYRoZNqY38BSEQAjVrXlvmax5h6OqD RxehPzEiw0RlB2iUn6MNbXsinPG0KD2pMF3QYrOk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yanjiang Jin , "Martin K . Petersen" , Sasha Levin , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.20 106/117] scsi: smartpqi: call pqi_free_interrupts() in pqi_shutdown() Date: Tue, 8 Jan 2019 14:26:14 -0500 Message-Id: <20190108192628.121270-106-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190108192628.121270-1-sashal@kernel.org> References: <20190108192628.121270-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yanjiang Jin [ Upstream commit e57b2945aa654e48f85a41e8917793c64ecb9de8 ] We must free all irqs during shutdown, else kexec's 2nd kernel would hang in pqi_wait_for_completion_io() as below: Call trace: pqi_wait_for_completion_io pqi_submit_raid_request_synchronous.constprop.78+0x23c/0x310 [smartpqi] pqi_configure_events+0xec/0x1f8 [smartpqi] pqi_ctrl_init+0x814/0xca0 [smartpqi] pqi_pci_probe+0x400/0x46c [smartpqi] local_pci_probe+0x48/0xb0 pci_device_probe+0x14c/0x1b0 really_probe+0x218/0x3fc driver_probe_device+0x70/0x140 __driver_attach+0x11c/0x134 bus_for_each_dev+0x70/0xc8 driver_attach+0x30/0x38 bus_add_driver+0x1f0/0x294 driver_register+0x74/0x12c __pci_register_driver+0x64/0x70 pqi_init+0xd0/0x10000 [smartpqi] do_one_initcall+0x60/0x1d8 do_init_module+0x64/0x1f8 load_module+0x10ec/0x1350 __se_sys_finit_module+0xd4/0x100 __arm64_sys_finit_module+0x28/0x34 el0_svc_handler+0x104/0x160 el0_svc+0x8/0xc This happens only in the following combinations: 1. smartpqi is built as module, not built-in; 2. We have a disk connected to smartpqi card; 3. Both kexec's 1st and 2nd kernels use this disk as Rootfs' mount point. Signed-off-by: Yanjiang Jin Acked-by: Don Brace Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/smartpqi/smartpqi_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index c1efc182f5ea..6f4cb3be97aa 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -6673,6 +6673,7 @@ static void pqi_shutdown(struct pci_dev *pci_dev) * storage. */ rc = pqi_flush_cache(ctrl_info, SHUTDOWN); + pqi_free_interrupts(ctrl_info); pqi_reset(ctrl_info); if (rc == 0) return; -- 2.19.1