Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Bernd Edlinger <bernd.edlinger@hotmail.de>
To:     Ping-Ke Shih <pkshih@realtek.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v4 1/4] rtl8723ae: Take the FW LPS mode handling out
Thread-Topic: [PATCH v4 1/4] rtl8723ae: Take the FW LPS mode handling out
Thread-Index: AQHUp6RmDijYI8GSZ0Oks0cNbTl2qw==
Date:   Tue, 8 Jan 2019 22:49:23 +0000
Message-ID: <AM6PR07MB5608D3B84CFB7EB8A84C2030E48A0@AM6PR07MB5608.eurprd07.prod.outlook.com>
Accept-Language: en-US, en-GB, de-DE
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [zuLHMHZlQpP/+x4ZPW57g99Qfdsn9ohz]
x-microsoft-original-message-id: <b58c84d9-67f5-f990-dfbb-82dae7f9bd2f@hotmail.de>
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;AM5EUR03HT054;6:lhYrEg4+zKIMnSDWaoaa6hz6PZCI2bLQUnyofGcyg2WuxwEyGCAuBFTYj88z1+HdEnHhrasULLPGmyWsmAtyIVMXsFhvoS/xKGaayYyUyUg/6K049YAkPJutBYI7Zd+84IygDUTUesAA5CHG0xn8w3tlEDBI/I0qA0mRlZ8JbgdEvwiNVB6UF7g7cfh97EJLcO1wETi19dKU0U+la6/PAQl3qQPn58wbDZEXAzIkB57FAoSX0gqLZVO03iLCVlSlFAv7mXw7zlRwqXknkpq2x8LqyDb7qLil3/leYLB9OXc124XalaH6XaxP/omeLDRvDruLaImFvl695GO5nkc/YZPY8LC/7y7F8OxNNvai5gzle7tlcvmOKmPo0RFJHLFKkzgVRaqnRl5Js1uE/MRB4U8BvQjp9i9ZsKuEzw4ANcss3lzctQ9uf0Gf1EFtasH4DifiqwY3jZK3Bu16B4QOYQ==;5:+jttb/sdstd1EH2eSCQJsO8qE9QERp7L8NDnBB+D84wjw8yjLxfqYKVRiORBCvFneUhEEAd0Sr0bw6sVRV/g9UpF7+uNMai/RcHM3P8Qv1K8dTY3hB0wWH9rT0YJv7CYonU+ikhOopavI6uLgtk/0oOBwRFhBi+bjEw0oZCYaic=;7:htZOK6Wm38LnvkawIzELfVynqpH/kliVBJ1l/kvD6Fz+fRu+KpCzBa2U/F0IrsHoAJJUEhegAv7dVtwGHaushE1yLvKW7r1x8pDnF6ep4IjGNb945lp8LczQ+elfGzA9kGrcI0qpYULfDuy4XieROA==
x-incomingheadercount: 62
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045);SRVR:AM5EUR03HT054;
x-ms-traffictypediagnostic: AM5EUR03HT054:
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(4566010)(82015058);SRVR:AM5EUR03HT054;BCL:0;PCL:0;RULEID:;SRVR:AM5EUR03HT054;
x-microsoft-antispam-message-info: qGgv7u71Tk8ay/H1hM3Ycc8ml2B1UTdYjx/+7bv9vm9UHSdJtym9sfDaJULtplBo
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <5C60488ADFDF104693C168DE625A0E9B@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: d4d70346-2c10-4f39-8c00-e767963926d9
X-MS-Exchange-CrossTenant-Network-Message-Id: d0a313bb-3526-41e6-8648-08d675bb88a5
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: d4d70346-2c10-4f39-8c00-e767963926d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2019 22:49:22.8475
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR03HT054
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This appears to trigger a firmware bug and causes severe
problems with rtl8723ae PCI devices.

When the power save mode is activated for longer periods
of time the firmware stops to receive any packets.

This problem was exposed by commit 873ffe154ae0 ("rtlwifi:
Fix logic error in enter/exit power-save mode").

Previously the power save mode was only active rarely and
only for a short time so that the problem was not noticeable.

Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
---
v2: Adjust the defaults of swlps and fwlps module
parameters to match the firmware capabilities instead of removing
the whole code, so it can be easily re-activated once a firmware
update is available.

v3: Make the title fit in one line.

v4: Try to fix the line endings the message body.
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c
index 07b82700d1..3103151 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c
@@ -266,8 +266,8 @@ static bool is_fw_header(struct rtlwifi_firmware_header *hdr)
 static struct rtl_mod_params rtl8723e_mod_params = {
 	.sw_crypto = false,
 	.inactiveps = true,
-	.swctrl_lps = false,
-	.fwctrl_lps = true,
+	.swctrl_lps = true,
+	.fwctrl_lps = false,
 	.aspm_support = 1,
 	.debug_level = 0,
 	.debug_mask = 0,
@@ -395,8 +395,8 @@ static bool is_fw_header(struct rtlwifi_firmware_header *hdr)
 		   bool, 0444);
 MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n");
 MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n");
-MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n");
-MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 1)\n");
+MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 1)\n");
+MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 0)\n");
 MODULE_PARM_DESC(msi, "Set to 1 to use MSI interrupts mode (default 0)\n");
 MODULE_PARM_DESC(aspm, "Set to 1 to enable ASPM (default 1)\n");
 MODULE_PARM_DESC(debug_level, "Set debug level (0-5) (default 0)");
-- 
1.9.1