Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190107185039.190919-1-rkir@google.com> <20190107185039.190919-3-rkir@google.com>
 <20190108121335.GA3349@kroah.com>
In-Reply-To: <20190108121335.GA3349@kroah.com>
From:   Roman Kiryanov <rkir@google.com>
Date:   Tue, 8 Jan 2019 16:48:02 -0800
Message-ID: <CAOGAQepF4R8ry+irPxeL=G0yFqhxRmkMWd_iPGYOTFzdZSj6iQ@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: add a driver
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> You have a number of WARN_ON() calls in here that are not needed, please
> remove.

Thank you for noticing, I will remove them.

> Also, why is this driver needed at all?  Why can't you use the "normal"
> drm sync api interface?  Why write a custom ioctl driver just for this
> one kernel interface?

This driver allows us to talk to host's sync api.