Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp272432imu; Tue, 8 Jan 2019 19:39:00 -0800 (PST) X-Google-Smtp-Source: ALg8bN679dYQ3gBbJemIJCaIO3g/z2LN4AWd5WgCjYMxk53WNUkYt+4Q0/YvRFXwkykTR5eHlG4n X-Received: by 2002:a62:2b8b:: with SMTP id r133mr4351416pfr.246.1547005140127; Tue, 08 Jan 2019 19:39:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547005140; cv=none; d=google.com; s=arc-20160816; b=RvHyKEkqfGbOtEdzBolp4SumH7aY0AiFc5eM+KPh/gP0zzkwLbJ+3g6Jg3S5y+Q9Ss XSKflRgYtQhTtB7SSBt9Wj7jP6yX4/vT+qlu7Zn1EerzVZimNh1H88rMXDpETRB3cdba eEImTzLeL1ewuWTaEZHWcqMaddBRq85110rZI3HyVCBg8rZ88W6/dDFYmWT3BleNkhLY TJB+hErCDnBhhlFatZd5GcXVCfTln+kg6pn2IN2AWntKL4HEcvSNrBFDtnykLo0CWxBf Faf383cfXjl/TWLGe5yBlDs1ZobQwWcxdfRDN57JcOB+HYKMeYlM47AdFNn3g5eQJ8Kq fNKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=spBBlpVZSRLbv+Z/s2zdbrGS08E8MQ1eEGTk1+x01YY=; b=tp43jhgmjDGtxeHDDHpP62P5C0qQ98KxuRyZUayYaFO+oAQAIcCd64O60u1w4q2HPP peeHH3WrKGlei9KBxQ0xfp7AIFqi9z4Ck3iD/F+slE5Z2F861BXO4cW89uJWaCW31ubW KC6Q86NV/LNASCO/C+HEr1AafbYUZo7OGBLNEBEZj44sa/BTbzLE6cZaI7NIGocIOpxJ ME9S7oJi5pnHBtWEV+zljQUgC+yLXQ2KSfzMM+jN8NgsxL80a1vHh/rNAmTebHEfyhIr XhYiM5Mjbs+BU1A2IzibLIXem+IFmg7cZS41p9egb8f1di6uw36R/YPPdVSfTFdjo1KA uM7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jN9rpB0N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si8824609pge.384.2019.01.08.19.38.41; Tue, 08 Jan 2019 19:39:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jN9rpB0N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729169AbfAID33 (ORCPT + 99 others); Tue, 8 Jan 2019 22:29:29 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:59672 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbfAID33 (ORCPT ); Tue, 8 Jan 2019 22:29:29 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x093O7mr002323; Wed, 9 Jan 2019 03:29:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=spBBlpVZSRLbv+Z/s2zdbrGS08E8MQ1eEGTk1+x01YY=; b=jN9rpB0Ne/DqaqzdTf90Eeb5P6UOUHulsKbay3FQJf1RyuXicdfjoGodd0Ys8YXlWR/J 0fPy/xB5STylVg4egzlDik0Z5y+rOA3h6G5TZMbvQEyyV365kmjtdJfU+ceY4ZztZCmH ZWFs5ZboeSG2to8pTdjuS3JKmSq9+Kb6r/fzEy5H0gSVKs+QNNM1GAx7lSlOKRtTcwc/ V02VdPmXSoYcgv+B4j4fn14rYesJMbc8gDoOHyXaWYQJYrp7KlM8mOGT1QiFRxZiB28m BezQL/GiVW72y+Df+m9npT2qLbU18JQ0sfWj1B7AT9YYsmou9hLx7vCd2gpdbY7Deuje ag== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2ptj3dy8wx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Jan 2019 03:29:15 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x093TE8v025019 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jan 2019 03:29:14 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x093TCdS023074; Wed, 9 Jan 2019 03:29:13 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 08 Jan 2019 19:29:12 -0800 To: Logan Gunthorpe Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Intel SCU Linux support , Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , Christoph Hellwig , Jens Axboe , Jeff Moyer Subject: Re: [PATCH] scsi: isci: initialize shost fully before calling scsi_add_host() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190108205043.3122-1-logang@deltatee.com> Date: Tue, 08 Jan 2019 22:29:09 -0500 In-Reply-To: <20190108205043.3122-1-logang@deltatee.com> (Logan Gunthorpe's message of "Tue, 8 Jan 2019 13:50:43 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9130 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=566 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901090026 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Logan, > To prevent this, the calls to scsi_host_set_prot() are moved into > isci_host_alloc() before the call to scsi_add_host(). Out of caution, > also move the similar call to scsi_host_set_guard(). Applied to 5.0/scsi-fixes. Thanks much! -- Martin K. Petersen Oracle Linux Engineering