Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp489587imu; Wed, 9 Jan 2019 01:02:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN6SN8Cw8OoJsEPzHie6K3Zy2WXNqma3GSsg7hz4CeiiBEuaFUDfZA+sLxbWl+B9hpvknATt X-Received: by 2002:a17:902:2aa8:: with SMTP id j37mr4978740plb.226.1547024545302; Wed, 09 Jan 2019 01:02:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547024545; cv=none; d=google.com; s=arc-20160816; b=mLGGalRp0iVwVVv69YH6UCF4WkI7vOXUI6Chesn9S7XoxNe0vfC7DnTdOK6mnOufZc bGx3ikd1ZG236Ur+I8eDuZcCC//0/wnmJ5PHMwfomrDGbVFziMFs3CcBMdWvmj9Bi1Cz CJOZrg93hujBksic9gN9w6Z9d6bnJYYvlzLUh64SdNB+RAyavhs1gmQW20gp+u6xJWxm z2UPU96pbiDQm56OLqASQnTIxv3sRgXdQr1UqJpBY8EQGrrzZ/JZW6JRsd9kuffJZEfO TfZECPuj/fT7MyBya4ZLp3auP6r83A4INIIl078QizMpnxTV8nos27gQc5CF6HyDQiWn ulGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=5TgjE5Tc//Ey4KRCrEBUNKc5Zm2Bcs7gVi6WSkJCjlM=; b=OP6AsV3foL2NHLIRPSQXv7m5p42MF4sra5GuVFl7g0FcaBSTeoqr1NAb8xvLhZBueK 0l11fDQnuw3yKDU706Rc8BYfGstdP/G+kSsQyI5dYz+62GKOPZ2XTxoSNFEc6JO6/N6q qdYkUWgpjmdqgj+UlVgSuejtYnuGsxkIDhXGVTWQldW+APUYGSrEe4ZP8HJc3aTFwrYD gkKEk797FGPLSXqQPhN+5/X70Y9qF2e83PuJ2TIR/faxm5hwoAwzcASO7TJV9aJ3IEOK 7cvNYKopMbwYEDMHXvKcE9uZ9N87XPnZA2/O3R6M7VcTTLzuhZl8zHp0eF+t45tG8TZk ymZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Cht7Uqex; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v141si71564260pfc.260.2019.01.09.01.02.08; Wed, 09 Jan 2019 01:02:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Cht7Uqex; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729821AbfAII2Y (ORCPT + 99 others); Wed, 9 Jan 2019 03:28:24 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:46185 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729721AbfAII2X (ORCPT ); Wed, 9 Jan 2019 03:28:23 -0500 Received: by mail-ed1-f68.google.com with SMTP id o10so6530282edt.13 for ; Wed, 09 Jan 2019 00:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5TgjE5Tc//Ey4KRCrEBUNKc5Zm2Bcs7gVi6WSkJCjlM=; b=Cht7UqexD8T1Ka5UqjIPEExH8jDEJdt+6WqGaCt7wd0tx8F3omd62OLajdOA+fygHi 1AoEMBPRJS+F14CqC58JIojNT37koybR+fxB/a7LpPLzRINIy6Kr+gMx5xH6gfzJWS2X m3leW76t8dImgfa3O7UMV0DUG7YRnGUZHziCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5TgjE5Tc//Ey4KRCrEBUNKc5Zm2Bcs7gVi6WSkJCjlM=; b=bh3XEWBzETTcg/HZcsF9ZqP1x1unbezwMZHdyLbxleCWYk0EJqkOluxJmag/5IbutO xzs81m3bcpe/tJd4r/hMhZeMVA+IEPJR30lnxbnzb2uDC2GnUNv11a+SR27tLBfC/GEe ADmv1kif/H+1OnxcFkg/D6iCukwB1WIA5c2OFIMJI47DF1mqSI9qCvad2Z2RXWmwW2gN Dy67EtHAIBNFRh1d6jf0CBru2CC1ouF6iaW04IQj5FrQzTyyErGCkpU2YGC4RS54SEVU 9creLBA0RH3Qk7OnBs0KBckhnrVQLjODj2HP7f6aVEsHmXxfsOLVBEdnPMeGdOZvMWyT Cemg== X-Gm-Message-State: AJcUukeXNrxzvl7xkS2WK6xSOvTHoi0gGgi6BfbGmYwJlN9xvvmY5Rwu yRc2VRc+cKl/9Rf7d5vQDp3vwpq5cB5huF7cypfHbYskqYlWbGjoiHYMWMZpl+6gE8tlruahR6k g72DQ6fl1sRX0KzvX/cGrTuUn4iXaXHtKFME4EXeophrsRFtVGGUmmqBLXWgIgx9IyztLFx/SQx 1C/UIAB7Zedpk= X-Received: by 2002:a50:cc04:: with SMTP id m4mr5229995edi.171.1547022501849; Wed, 09 Jan 2019 00:28:21 -0800 (PST) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id j31sm833826eda.46.2019.01.09.00.28.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 00:28:21 -0800 (PST) Subject: Re: [PATCH] net: brcm80211: add a check for the status of usb_register To: Kalle Valo , Kangjie Lu Cc: pakki001@umn.edu, Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Pieter-Paul Giesberts , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181226012227.70524-1-kjlu@umn.edu> <87zhsbqeuu.fsf@kamboji.qca.qualcomm.com> From: Arend Van Spriel Message-ID: <7ddb04d4-f45f-2b41-12da-d17e8f8c1173@broadcom.com> Date: Wed, 9 Jan 2019 09:28:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87zhsbqeuu.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/8/2019 5:43 PM, Kalle Valo wrote: > Kangjie Lu writes: > >> usb_register() may fail, so let's check its status and issue an error >> message if it fails. >> >> Signed-off-by: Kangjie Lu >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++- > > The title prefix should be "brcmfmac: " but I can fix that. Hi Kalle, I wanted to ack this patch, but can not locate it in my email not in linux-wireless patchwork. Was it posted to the networking list only? Using scripts/get_maintainer.pl with the patch would reveal the lists to post to in order of preference. For wireless driver changes I refrain to linux-wireless only, but that is a personal choice I guess. Regards, Arend > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong >