Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 9 Jan 2019 04:30:16 -0500
From:   YU Bo <tsu.yubo@gmail.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>, yuzibode@126.com
Subject: Re: [PATCH V5 2/2] kobject: drop newline from msg string
Message-ID: <20190109093014.cjheviy67szigzfg@yubo-2>
Mail-Followup-To: "Rafael J. Wysocki" <rafael@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>, yuzibode@126.com
References: <cover.1547024167.git.tsu.yubo@gmail.com>
 <db8c353e82b944654fec17beb99d96bebff91864.1547024167.git.tsu.yubo@gmail.com>
 <CAJZ5v0guQizE2mi3qv=0CVz9FYf6Kzv222Ff0RX1NyGuKAiucA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
In-Reply-To: <CAJZ5v0guQizE2mi3qv=0CVz9FYf6Kzv222Ff0RX1NyGuKAiucA@mail.gmail.com>
User-Agent: NeoMutt/20180512-62-03f98a
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 09, 2019 at 10:21:37AM +0100, Rafael J. Wysocki wrote:
>On Wed, Jan 9, 2019 at 10:17 AM Bo YU <tsu.yubo@gmail.com> wrote:
>>
>> There is currently a missing terminating newline in non-switch case
>> match when msg == NULL
>>
>> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
>
>I have given you an R-by for this one already, so why haven't you added it here?
Oh, i got it.This is the first time i encountered the circumstances.
>
>Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thank you :)
>
>> ---
>> Changes in V4:
>> Recovery originly declaration, requested by Greg.
>>
>> Change in V3:
>> Improve the commit log, requested by Rafael.
>>
>> Changes in V2:
>> Drop newline from msg according to Joe's suggestion.
>> ---
>>  lib/kobject_uevent.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
>> index c87a96c4800e..f05802687ba4 100644
>> --- a/lib/kobject_uevent.c
>> +++ b/lib/kobject_uevent.c
>> @@ -200,7 +200,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>>
>>         r = kobject_action_type(buf, count, &action, &action_args);
>>         if (r) {
>> -               msg = "unknown uevent action string\n";
>> +               msg = "unknown uevent action string";
>>                 goto out;
>>         }
>>
>> @@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>>         r = kobject_action_args(action_args,
>>                                 count - (action_args - buf), &env);
>>         if (r == -EINVAL) {
>> -               msg = "incorrect uevent action arguments\n";
>> +               msg = "incorrect uevent action arguments";
>>                 goto out;
>>         }
>>
>> @@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>>  out:
>>         if (r) {
>>                 devpath = kobject_get_path(kobj, GFP_KERNEL);
>> -               pr_warn("synth uevent: %s: %s",
>> +               pr_warn("synth uevent: %s: %s\n",
>>                        devpath ?: "unknown device",
>>                        msg ?: "failed to send uevent");
>>                 kfree(devpath);
>> --
>> 2.11.0
>>