Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp537317imu; Wed, 9 Jan 2019 02:02:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN675zzZhRMe7nxxJmF48oYUakK4eNWzgwUr7Z9WBykNaRRf1NCKUiHOriXiFho9iGZgIGla X-Received: by 2002:a62:520b:: with SMTP id g11mr5383664pfb.53.1547028168737; Wed, 09 Jan 2019 02:02:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547028168; cv=none; d=google.com; s=arc-20160816; b=wDEjg5MdohZPtkVP8YSn7HPis6zmOxJiI0rI7A5/ItfacpfY9MF4kh1ML5zJ9ccJ65 TGlvsFe18DzCX4b6P3W5BJQvSnINgwCZQzxDiPuyKJbLEU8DHo2AJNqClsknT8ukzGNx LT924XULofsZ80apLF98oyJDUjJ5GqPJH0Sqvc+BaBtD3g7ZjACGQRTXaYJd//CBd6it pGVjvSRWrF95APx/tfd3Q+CNu6Rmp42r42SNgUId/xzgshA22K5OHVQDp8iaxlT3YrsX EJC9F3bCKbsaBuyBDsYbQolQcBl3ahupN8bL9dACvuhslHnnPN6QKJbtuwb5x1S+sYPc nMsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=13DAwGIcZbDE6y55GldF98FlJBg/ruKsjhIbPFxhRyQ=; b=yz2ICBwU3izZ57kpC5H7w8PJmHWdgHrKbyGTKswp1FQuxaLDa4drnBV/CKxkIm8zUN QOWO+5+2+VCEIbvV5F9cN6/V2UJXP3nNeFZnmxgqFVUXR7ZBAsnwyZoPGvmvHCVJYhNN 84r5nX6rZoXVbSmrXwlyh8Wb8JG7qRU1Zdp2hdHIYaqK3efnkbICb7FqmOy6mA4yKdVC z9OgthuqVlD33uVu10Cbwd+diw3vVYUd7rUJQGud0HEz4mr9qJYN+CMwxeBYj0bOZ9X0 mrLugRM+OH1gyDqjBw3hBqMo8wLsUeIAeXZnaW7z435cgtSAeDK+Oh6+CmONfCdTJmRN 23XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f186si70098963pfb.67.2019.01.09.02.02.32; Wed, 09 Jan 2019 02:02:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730319AbfAIJUa (ORCPT + 99 others); Wed, 9 Jan 2019 04:20:30 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:32855 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729926AbfAIJU3 (ORCPT ); Wed, 9 Jan 2019 04:20:29 -0500 Received: by mail-oi1-f196.google.com with SMTP id c206so5783120oib.0 for ; Wed, 09 Jan 2019 01:20:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=13DAwGIcZbDE6y55GldF98FlJBg/ruKsjhIbPFxhRyQ=; b=cFrrPBDgFTGzHAYKLswugyHA7w4n6ZyFSEM5NYfg+ZjzT3aCdOF/ukLsA2pHpv43rc uav6LCNJE6satkddtY7hM0OoEGnom8IEA5zLB8Aew7CxhqEkLfjlVGZIYcegERbBgDxL nfR2GEypWvtS3f9ggyQWpwV1uurITH1TBTua/l5Wu4Y9fM/n0iHfWnh+G8xAH96m6y9h VJPt21rzhzCP96h6Y6uk2M/8nlzRBl7N1iNPWS6D/Y/LwpOIr+R6j2TA8TdUkvu5Bp6B n2H4PoDpztRLsC8xZle4Rjh5oUhMi3MPLF3JwrWbqENKkZgE6wqOsThoEMVBmVolgs9F sReA== X-Gm-Message-State: AJcUukfXXAfOyhZYXfuEoK8shVgmQ/BAGgpLqKSYwc/0ucTSYely2Xfb TXz7XRXwVDTxJYtpNUWMuwXSzy1rKjzNIdPp4mM= X-Received: by 2002:aca:368a:: with SMTP id d132mr3583767oia.193.1547025628990; Wed, 09 Jan 2019 01:20:28 -0800 (PST) MIME-Version: 1.0 References: <99e9edd31414bd240286b5b63b39140fc74e6ca5.1547024167.git.tsu.yubo@gmail.com> In-Reply-To: <99e9edd31414bd240286b5b63b39140fc74e6ca5.1547024167.git.tsu.yubo@gmail.com> From: "Rafael J. Wysocki" Date: Wed, 9 Jan 2019 10:20:17 +0100 Message-ID: Subject: Re: [PATCH V5 1/2] kobject: to repalce printk with pr_* style To: Bo YU Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , Joe Perches , yuzibode@126.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 9, 2019 at 10:17 AM Bo YU wrote: > > Repalce printk with pr_warn in kobject_synth_uevent and replace > printk with pr_err in uevent_net_init to make both consistent with > other code in kobject_uevent.c > > Signed-off-by: Bo YU Reviewed-by: Rafael J. Wysocki > > --- > Changes in V2: > Improve the commit log, doing as the patch did. > --- > lib/kobject_uevent.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c > index 27c6118afd1c..c87a96c4800e 100644 > --- a/lib/kobject_uevent.c > +++ b/lib/kobject_uevent.c > @@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count) > out: > if (r) { > devpath = kobject_get_path(kobj, GFP_KERNEL); > - printk(KERN_WARNING "synth uevent: %s: %s", > + pr_warn("synth uevent: %s: %s", > devpath ?: "unknown device", > msg ?: "failed to send uevent"); > kfree(devpath); > @@ -765,8 +765,7 @@ static int uevent_net_init(struct net *net) > > ue_sk->sk = netlink_kernel_create(net, NETLINK_KOBJECT_UEVENT, &cfg); > if (!ue_sk->sk) { > - printk(KERN_ERR > - "kobject_uevent: unable to create netlink socket!\n"); > + pr_err("kobject_uevent: unable to create netlink socket!\n"); > kfree(ue_sk); > return -ENODEV; > } > -- > 2.11.0 >