Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp543151imu; Wed, 9 Jan 2019 02:08:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN7A8Qr43iOg5AmylRS6fsOENoURxdIfwrkRIGqti4sa39N/tGeCp2rjVuGG5r7Tdlg1ZzZO X-Received: by 2002:a63:2ac9:: with SMTP id q192mr4821860pgq.58.1547028524648; Wed, 09 Jan 2019 02:08:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547028524; cv=none; d=google.com; s=arc-20160816; b=XSGobd882Q1H/pNF0Nsh5FT93SC/OMd4VYqQSwYZSznX+o1wcCnx20B737MbVlBExY d7cq1rxv9sRI9U3wNtUuiZMc+iwaAIc5cNIesHuxpNEEEkY+9Q70D8NSyjkvbXWAcoDy n0hvRuQCVZvA6RSFU9MLum6VDQ+SziPtSLaShQqb7KHz6Fe2217dRynjFd4r+4WWXnXq OUO+T/fdofYwXIG6j3ZC7uG+4HvZpylGiV7GDUr+bbxoI/OC6g4xQoB4ytD9+sAUCftn mbjw3lLz4yD3OO2RUrtfVRTduOshjXDKxfXxjXrmvE8dm3JdAogTdLQkj1ueXhoCP4pd nTuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=GAFO7TskP97VYpu3XsgpC/oXxOYoUKDGbosp3GLmquc=; b=j2u7izTuigHA7EKtkIelJpgi/EFML55nk3L3xAhmgdJD3bnoFW1HzsDislZaE9tD3s vNwRHyUiVm7ihiu5bkSYeBL0dW67KDKn2O6Q4vMQjVcahtaMSCLfGAMf5cVOB6l0FhaE ASEWw3k4P3vAoJ7bv14rccKuCf4U9qczOy0YeUWXGTtQeum6RVUtvt2ZsXiY8IFdtwtz mzgQLJWPPEjt19RUUMywJu41GoW5vC1ypNR1mFvU+KCAyRVWTbmCCjrHJxZN24D7hSml 76IBkCrPzB2ZuQCKcFxZoUogEkUmR8lqFzRpTAyt+br1eQ6HWWxd2XmOoVd4MXeEN94M vIDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c81si13099889pfc.82.2019.01.09.02.08.28; Wed, 09 Jan 2019 02:08:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729787AbfAIJ4s (ORCPT + 99 others); Wed, 9 Jan 2019 04:56:48 -0500 Received: from foss.arm.com ([217.140.101.70]:39560 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729132AbfAIJ4s (ORCPT ); Wed, 9 Jan 2019 04:56:48 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82D5D80D; Wed, 9 Jan 2019 01:56:47 -0800 (PST) Received: from [172.16.1.159] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 65C363F70D; Wed, 9 Jan 2019 01:56:43 -0800 (PST) Subject: Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver To: "gregkh@linuxfoundation.org" Cc: Borislav Petkov , "Wiebe, Wladislav (Nokia - DE/Ulm)" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "nicolas.ferre@microchip.com" , "arnd@arndb.de" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mchehab@kernel.org" , "Sverdlin, Alexander (Nokia - DE/Ulm)" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190108104204.GA14243@zn.tnic> <20190108181206.GA3848@kroah.com> From: James Morse Message-ID: <52dc5125-9213-9ee4-eca6-cc8ffbc869f7@arm.com> Date: Wed, 9 Jan 2019 09:57:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190108181206.GA3848@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 01/08/2019 06:12 PM, gregkh@linuxfoundation.org wrote: > On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: >>>> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c >>>> new file mode 100644 >>>> index 000000000000..26252568e961 >>>> --- /dev/null >>>> +++ b/drivers/edac/cortex_a15_l2_async_edac.c >>>> @@ -0,0 +1,134 @@ >>>> +// SPDX-License-Identifier: GPL-2.0 >>>> +/* >>>> + * Copyright (C) 2018 Nokia Corporation >> >> (boiler plate not needed with the SPDX header) > > Not true at all. Copyright is not the same thing as an SPDX license > identifier in any way, shape, or form. As-is, this is just fine. This looks funny because I removed the GPL license text that was here, but left this comment when trimming the reply. I should have left a few lines of it for context. (Originally: https://lore.kernel.org/lkml/20190108104204.GA14243@zn.tnic/T/#u) Thanks, James