Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp561396imu; Wed, 9 Jan 2019 02:30:46 -0800 (PST) X-Google-Smtp-Source: ALg8bN60+Pcw+X1qV3b2Y2oMyfW/e4CuL7actf7grObGEWuOtuou5zid0m9t0CWPy/OoaDOzeATv X-Received: by 2002:aa7:80d7:: with SMTP id a23mr5327239pfn.86.1547029846867; Wed, 09 Jan 2019 02:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547029846; cv=none; d=google.com; s=arc-20160816; b=NyXGYXYL2msXdouyu9K2xMhUwrm0qkT8/6hIovl3TLYuAoN3i56Wiy9UwWdO6bC0SU 4ooBBNukoXx2qJFqjQLjAEh0A6wDf67FKFXhaI5BY/AQ7aee2GocS0VzHbC0yg3Hvqz4 pAN7IoJM0TCSqguTTjpVYQtq8npyhpTCrtEQpN1QesCuSXM2WBGhT4FE2k3hyYo5gHIC ZyY2TOgChK3kUdOgW8dVMhC2Hhp2HYuIBR3QcoeLIeKdEBvb7Xh8UOT1yoDEuuP5uhyd uG8Dn9DH7ikm+6na2OWj7tDkeRBO/EvSypWriZ7UprDtpzukHSKwWUZRo9Jd63IZbf9l fUSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=dcSfptL6+xloYtIin3+WP6oU7QPChUtfZquybxIvKOo=; b=AZXxYl2yYrGs+KmwFXCH4eCzcmoSU8PEng1+tDxblcC8fnZ6eY8/PalcZrHJnnmpT9 G1LZQyw28hFC9sBvPvNBiNMxTq6lIM3E10WD+XcmxACJB0cX4efncZjRXExSvj81mKAi yivhDJiqIgk3Zfg3GjxppiA2hdgr9+ngru0WM06YrVLPzyNpPbEZDPhhF3qbdZ9BQ2aB CFqvKEUAdcgJqZGQXWPyarYzmkLBjxp+bviHVGiN428rwhUxxoSn+youB1LA5pk1A9tL fyClmwz/Jik9V0P5hBsh12ZWYHrork+fF611A9kloTqMtcw1xSWkBdxpjbWZiw7hJVwO NcXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=GSctGjhw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si12475179pga.506.2019.01.09.02.30.31; Wed, 09 Jan 2019 02:30:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=GSctGjhw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730381AbfAIJmX (ORCPT + 99 others); Wed, 9 Jan 2019 04:42:23 -0500 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:6461 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729402AbfAIJmV (ORCPT ); Wed, 9 Jan 2019 04:42:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1547026940; x=1578562940; h=from:to:cc:subject:date:message-id; bh=dcSfptL6+xloYtIin3+WP6oU7QPChUtfZquybxIvKOo=; b=GSctGjhw/h9C6ppXvJNoG/CNwNlQ34Ns+EauXOXafBerewNw8hZ5SkY9 krGzhLJyeZ5xDWTxC3RYTbNjVOlSyWH2MszOPDDLbC5Z8N6Lzc8OkI4mt YkZcEXhD0xUnXK9NSgPzguUKuCfEpWrhcHB6cX/dU5dVrH0xrnk/CuEBi U=; X-IronPort-AV: E=Sophos;i="5.56,253,1539648000"; d="scan'208";a="712024354" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 09 Jan 2019 09:42:19 +0000 Received: from u54e1ad5160425a4b64ea.ant.amazon.com (pdx2-ws-svc-lb17-vlan2.amazon.com [10.247.140.66]) by email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com (Postfix) with ESMTPS id E2B1DA1F2A; Wed, 9 Jan 2019 09:42:17 +0000 (UTC) Received: from u54e1ad5160425a4b64ea.ant.amazon.com (localhost [127.0.0.1]) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id x099gFtM031290; Wed, 9 Jan 2019 10:42:15 +0100 Received: (from karahmed@localhost) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Submit) id x099gFYx031287; Wed, 9 Jan 2019 10:42:15 +0100 From: KarimAllah Ahmed To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com Cc: KarimAllah Ahmed Subject: [PATCH v5 00/13] KVM/X86: Introduce a new guest mapping interface Date: Wed, 9 Jan 2019 10:42:00 +0100 Message-Id: <1547026933-31226-1-git-send-email-karahmed@amazon.de> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guest memory can either be directly managed by the kernel (i.e. have a "struct page") or they can simply live outside kernel control (i.e. do not have a "struct page"). KVM mostly support these two modes, except in a few places where the code seems to assume that guest memory must have a "struct page". This patchset introduces a new mapping interface to map guest memory into host kernel memory which also supports PFN-based memory (i.e. memory without 'struct page'). It also converts all offending code to this interface or simply read/write directly from guest memory. Patch 2 is additionally fixing an incorrect page release and marking the page as dirty (i.e. as a side-effect of using the helper function to write). As far as I can see all offending code is now fixed except the APIC-access page which I will handle in a seperate series along with dropping kvm_vcpu_gfn_to_page and kvm_vcpu_gpa_to_page from the internal KVM API. The current implementation of the new API uses memremap to map memory that does not have a "struct page". This proves to be very slow for high frequency mappings. Since this does not affect the normal use-case where a "struct page" is available, the performance of this API will be handled by a seperate patch series. v4 -> v5: - Introduce a new parameter 'dirty' into kvm_vcpu_unmap - A horrible rebase due to nested.c :) - Dropped a couple of hyperv patches as the code was fixed already as a side-effect of another patch. - Added a new trivial cleanup patch. v3 -> v4: - Rebase - Add a new patch to also fix the newly introduced enlightned VMCS. v2 -> v3: - Rebase - Add a new patch to also fix the newly introduced shadow VMCS. Filippo Sironi (1): X86/KVM: Handle PFNs outside of kernel reach when touching GPTEs KarimAllah Ahmed (12): X86/nVMX: handle_vmon: Read 4 bytes from guest memory X86/nVMX: Update the PML table without mapping and unmapping the page KVM: Introduce a new guest mapping API X86/nVMX: handle_vmptrld: Use kvm_vcpu_map when copying VMCS12 from guest memory KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page KVM/nVMX: Use kvm_vcpu_map when mapping the posted interrupt descriptor table KVM/X86: Use kvm_vcpu_map in emulator_cmpxchg_emulated KVM/nSVM: Use the new mapping API for mapping guest memory KVM/nVMX: Use kvm_vcpu_map for accessing the shadow VMCS KVM/nVMX: Use kvm_vcpu_map for accessing the enlightened VMCS KVM/nVMX: Use page_address_valid in a few more locations arch/x86/kvm/paging_tmpl.h | 38 ++++++++--- arch/x86/kvm/svm.c | 97 +++++++++++++-------------- arch/x86/kvm/vmx/nested.c | 160 ++++++++++++++++----------------------------- arch/x86/kvm/vmx/vmx.c | 19 ++---- arch/x86/kvm/vmx/vmx.h | 9 ++- arch/x86/kvm/x86.c | 13 ++-- include/linux/kvm_host.h | 9 +++ virt/kvm/kvm_main.c | 53 +++++++++++++++ 8 files changed, 217 insertions(+), 181 deletions(-) -- 2.7.4