Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp630016imu; Wed, 9 Jan 2019 03:50:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN5Mf3W0mBhc98ccC6t5vVu+iD3OdIfbgsgUlBZn5Ps5IWb8uU8OxQc3xxKZ0e+qR3qT01C1 X-Received: by 2002:a62:4641:: with SMTP id t62mr5573504pfa.141.1547034640014; Wed, 09 Jan 2019 03:50:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547034639; cv=none; d=google.com; s=arc-20160816; b=IA8wPvQzPWw9khOUEkOPdn2MxFkQL93TXvi8mufm4HllK2c0uv4QqXHDGnrGUy58Ob WNhWvPy6avA+cacpkax+MNadfFCtgCRUvvU6tXyXwOz1DWqafOB+72DDbq1j7FPx7skv L4yNi7RmtJ8gHUYa90DQ4xjOYz+JTFEuFgIuONHbYMbNKEtIuGuv7qi1z0NdMJrpzx3Q lt9z5oHng7YrFZhW/abb8P7JODYySRF/tJsP9WHyqDQBIl8DmCXQuuhGYiuTwBchxu9T QPM6MfL4ZWZZdTsvpPlaSZKYE8y5JfBjl/r17qG7SvDitJSppBIhSd/KszQQoFxAU2Np iAaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sDoxHAhlPA04hTeozlLuf8XsGBWu6hTBtPu5x26V9lQ=; b=U8hkfpcJanyNvv9AugueRSopoy9wH7cWo0/LsuVXsjwdwkZ8mZ2j64QwplSu7lNmXx UU+YVXR60EA3i4ZKoD8HmE6slKwRR8RpTR7ejRWy0zTV4SfG7M9prOekpeh2d6o9c7BJ m6zZiNEeXci0rLHEzKQJFN86sPIb32smFFm9h3hh+4MuG3PbPLz0wLwm5voQFv556IBr pE1VD4tMJo7u7oCUNF5dUoZhlbhf+Fq0Q+/rnXiJdU1Sgf/OfAZa2e3d/wng032tK1ts xW95ae8aniXSAYnmzNUUQn3P8e5CTy5l0D4yBegwGapDHI3k24ZkaoiQHN93Kxn5hSnP SeUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=PrhFPAUA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l23si63861822pgh.533.2019.01.09.03.50.24; Wed, 09 Jan 2019 03:50:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=PrhFPAUA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730543AbfAIK6Y (ORCPT + 99 others); Wed, 9 Jan 2019 05:58:24 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:35378 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729752AbfAIK6Y (ORCPT ); Wed, 9 Jan 2019 05:58:24 -0500 Received: by mail-lj1-f194.google.com with SMTP id x85-v6so6119817ljb.2 for ; Wed, 09 Jan 2019 02:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sDoxHAhlPA04hTeozlLuf8XsGBWu6hTBtPu5x26V9lQ=; b=PrhFPAUARi7Nuq4LMd++Q8dGeaNLxSzYlEQtyxtWjEC/4tReJ7c0c4wtKZTOztCO7M xB/9PQ9G7UR+T5d6nAJeda3MmOFTitSFF+z4HlFDyYuj4gX9Bv9bED/0DD111Tuw0327 zjxvJxrXH3c1kXgSO5y3DBHPOEBvE5tOcul7toxsvoL0Pqz01+C4FqLT6N+myWUdi+BH m4EFx8GnIxWnzqfCZCHUWi2TxwgTOlnxVd4dKtiqdlPKcea0Nzq32qjPpUS190Lznu2X lndRdzzZZRRMEUs8B5aNJ4FJA5MULA4PT5Qf3YeAkEVBUCauscD0Ju8N/M5EhA1bYFQC qn7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sDoxHAhlPA04hTeozlLuf8XsGBWu6hTBtPu5x26V9lQ=; b=ZLOObmckL0BExYoQvil2Hk4h//sU+W6eO+JqnMqRZLfFjpFxx18izLN1Z3XUSttAj0 twGGLKfXzNCUD4Z2HyAibHKcTP7Yaz6oPLGxYAIiI6Kqyxnn9UrIBR/CvutK9amXJGFt 1FfCzVGdXInadmETpCsJCDlxbd+a9gXwvw6d5VNZQLHcJunVmQb3kxI10LlWIz6fQzaD wv0XrI3CSxeFq25Wq9Zqfu2KofEJw1IfxgsGLcMUkTYmBAwzyRWNN1rB2PDR4SsaxeDl CKXIJ0IWOApxnbwlseNOYdd0naFMeuX9AX8gZ5nnsswh6S0w4+8kFayDwbfRPQp0m+aY p79g== X-Gm-Message-State: AJcUukeJvmysYnp2MZtFXmmZClFZ2wYFVyfj0cv9Soj7anpdkjOmMiWM 4v7hnZEB3KJ+WI7H+Z25wrDczmiz X-Received: by 2002:a2e:9d8e:: with SMTP id c14-v6mr3115145ljj.146.1547031501432; Wed, 09 Jan 2019 02:58:21 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id e97-v6sm14837455lji.51.2019.01.09.02.58.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 02:58:20 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1ghBZ2-000828-FY; Wed, 09 Jan 2019 11:58:24 +0100 Date: Wed, 9 Jan 2019 11:58:24 +0100 From: Johan Hovold To: Nishad Kamdar Cc: Johan Hovold , Greg Kroah-Hartman , Alex Elder , Rui Miguel Silva , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller() Message-ID: <20190109105824.GJ14782@localhost> References: <03b274a2b5777d67e9d9b6318b5b2f13ce5c2b66.1545488665.git.nishadkamdar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03b274a2b5777d67e9d9b6318b5b2f13ce5c2b66.1545488665.git.nishadkamdar@gmail.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > This patch drops gpio_chip_to_gb_gpio_controller(), > and uses gpiochip_get_data() to retrieve the container > of struct gpio_chip. So this will break the driver, since gpiochip_add() sets the data pointer to NULL. These kind of changes are getting too complicated to do without something to test against. We had a module simulator at one point, but not sure what the state of that is now. I appreciate the effort though, and since we already started, let's try to finish, but please drop this patch for now. Johan