Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp630276imu; Wed, 9 Jan 2019 03:50:56 -0800 (PST) X-Google-Smtp-Source: ALg8bN4FhIRwZnPjNqgVBV/Sdpep09f2esNK1hXG7+EFFrzfOrT0Yh5F4GgEP0dfZQb8wH6907G8 X-Received: by 2002:a62:64d7:: with SMTP id y206mr5675333pfb.84.1547034656840; Wed, 09 Jan 2019 03:50:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547034656; cv=none; d=google.com; s=arc-20160816; b=ZFuec0xL7BUA4YPotVZiee7y+m5x+bB0ht3FYRNGYCHsY4fz73i+TCEfJRlxxyjVlI 2wLPpntqIi/qcSH6IwRZaqJFMwMe4++ZC8nSkOXMCaTEfI/R9N0mtE4rl6TOPrkMoPDi c1bHbTGNKMQ9xm1Yd6H2sr4MDysMaqVyb3tnU/lZXqzkiqxqwN8vv/CdYiCQJccqFgNS GEOy/yg5E9GzoPXLXNdKYWpQOPAUNhqcQ6sMSVzQGgMtfU3Fir4tTzEGvsG7eChHVxV6 mJycXNpDdaEVdFynAM+eDFps1S3/FpxnOF2PmMFpXPh2xXb0pk/7hQ8mNnikHAOWMEiD 65Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature; bh=hVLkeTum+mOWjTOMocNv/ozFCVLZ39LTa1o0Uy3S5Ts=; b=I5OXy7nhXD2IgnATdqjUBYfnyGNDQusnmpC+I5FPEJRZYfjj32rGXd/PvqcoLUGM/G PTzXmz111FCBJOSozcso+A+XBdf3ToLWiEneD5ut9TMWDMLQi5ZU5qx2H+vigIdePzCv g7xck4JFqB6HJPcoVSlRi4ZaIskBnn+w0an1vfyIjOaXcqydalXtFQVGvmDKW662YSRG mOa14CG2f6r0Zi5dkwsVUSEQVLXi1lyhDwUWXkfDnSUNq8tS4daNvOliFYrszwb6aIvg sx27RKa5KlL7er7rNoYdzzklDfzzJut9mtr1wrxZzo8eu4obLVdydG/ldCiDIzDuoLEv 4iLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ZCQ69BOf; dkim=pass header.i=@codeaurora.org header.s=default header.b=bgwK6zku; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 85si68223090pfc.145.2019.01.09.03.50.41; Wed, 09 Jan 2019 03:50:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ZCQ69BOf; dkim=pass header.i=@codeaurora.org header.s=default header.b=bgwK6zku; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730651AbfAILGi (ORCPT + 99 others); Wed, 9 Jan 2019 06:06:38 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58136 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730174AbfAILGi (ORCPT ); Wed, 9 Jan 2019 06:06:38 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 516C56063A; Wed, 9 Jan 2019 11:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1547031997; bh=OZbgaGFt9Xz4LT/DKSijRLnaugoQQXKpGMFVf1zvLBE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZCQ69BOfZY+1Fy9P7Bcc1qW5GDYX3OX8FIrZ7AXn64Ts/DMqms5JBNsk/w9TEXY7q t50qxw4BBq5vgyk194OiO5jQCHQi/aO9qADfvSFn5z+tEeya4RK7DYhYNSfEVT+r4l k9uN858k1uA8k+M+3mZZ33cP/xIq1Mv4Wm4Pd3EU= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 8FD1C60300; Wed, 9 Jan 2019 11:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1547031996; bh=OZbgaGFt9Xz4LT/DKSijRLnaugoQQXKpGMFVf1zvLBE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bgwK6zkuyNp0rPUNso1nfFpesdzAL3E0cTGrNuMhQZu+3HpIzmRb5koB2vjPm7t4S f82MsdyZAST5fRRBflho3YzouADk7oIK6wo5gk6mbG2BWp6DzOoa/bkw7bmKY4W5lC hVLWGBB4HddM4xKtIEETEX1ep4F8Yi9tUF0IWJhs= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 09 Jan 2019 16:36:36 +0530 From: Arun KS To: Michal Hocko Cc: Alexander Duyck , arunks.linux@gmail.com, akpm@linux-foundation.org, vbabka@suse.cz, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, getarunks@gmail.com Subject: Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order In-Reply-To: <20190109105754.GR31793@dhcp22.suse.cz> References: <1546578076-31716-1-git-send-email-arunks@codeaurora.org> <20190108181352.GI31793@dhcp22.suse.cz> <20190109073718.GM31793@dhcp22.suse.cz> <20190109084031.GN31793@dhcp22.suse.cz> <20190109105754.GR31793@dhcp22.suse.cz> Message-ID: <2efb06e91d9af48bf3d1d38bd50e0458@codeaurora.org> X-Sender: arunks@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-01-09 16:27, Michal Hocko wrote: > On Wed 09-01-19 16:12:48, Arun KS wrote: > [...] >> It will be called once per online of a section and the arg value is >> always >> set to 0 while entering online_pages_range. > > You rare right that this will be the case in the most simple scenario. > But the point is that the callback can be called several times from > walk_system_ram_range and then your current code wouldn't work > properly. Thanks. Will use += Regards, Arun