Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S265846AbUA1D6N (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 27 Jan 2004 22:58:13 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265847AbUA1D6N
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 27 Jan 2004 22:58:13 -0500
Received: from fw.osdl.org ([65.172.181.6]:20353 "EHLO mail.osdl.org")
	by vger.kernel.org with ESMTP id S265846AbUA1D6L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Jan 2004 22:58:11 -0500
Date: Tue, 27 Jan 2004 19:55:58 -0800
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: jw schultz <jw@pegasys.ws>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: Trailing blanks in source files
Message-Id: <20040127195558.342dba6c.rddunlap@osdl.org>
In-Reply-To: <20040128034939.GE15979@pegasys.ws>
References: <Pine.LNX.4.58.0401271544120.27260@joel.ist.utl.pt.suse.lists.linux.kernel>
	<p73bropfdgl.fsf@nielsen.suse.de>
	<200401271251.34926.theman@josephdwagner.info>
	<20040127191358.GI20879@khan.acc.umu.se>
	<20040127111824.7f76efe6.rddunlap@osdl.org>
	<20040127160214.69850c9c.akpm@osdl.org>
	<20040128034939.GE15979@pegasys.ws>
Organization: OSDL
X-Mailer: Sylpheed version 0.9.8a (GTK+ 1.2.10; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1508
Lines: 35

On Tue, 27 Jan 2004 19:49:39 -0800 jw schultz <jw@pegasys.ws> wrote:

| On Tue, Jan 27, 2004 at 04:02:14PM -0800, Andrew Morton wrote:
| > "Randy.Dunlap" <rddunlap@osdl.org> wrote:
| > >
| > > So please don't bother with just whitespace changes unless you
| > > are going to cleanup a <driver | fs | module | etc> completely.
| > 
| > And if you're going to do that, do the whitespace cleanup _first_, so the
| > substantive changes to the driver/fs/module/etc can be sanely understood
| > and reverted if necessary.
| > 
| > I frequently sneakily remove all newly-added trailing whitespace from the
| > patches people send me.  In 15 years it'll all be gone.
| 
| This would maybe warrant a bk option to remove trailing
| whitespace from modified lines.  Preferably with an
| notification that it is happening so if for some reason you
| do want trailing whitespace you could abort or override.
| 
| A patch filter that removed trailing whitespace from + lines
| could also be used.

AFAIK Andrew already uses a script to check for trailing spaces,
and I do also.  Yes, it could be modified to be a conversion filter,
but it doesn't happen frequently, and when it does, I want to let
the poster know about it, so I like to have the evidence handy.  :)

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/