Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp934378imu; Wed, 9 Jan 2019 08:45:23 -0800 (PST) X-Google-Smtp-Source: ALg8bN56Ui3wpY3SRQkS9ryYOpQtCVlTkVU0H1TAv7iKwkRsSeLMAHeIY61I+vkcUd8o1s6haidz X-Received: by 2002:a17:902:c05:: with SMTP id 5mr6768256pls.155.1547052323911; Wed, 09 Jan 2019 08:45:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547052323; cv=none; d=google.com; s=arc-20160816; b=TR/lLwRzAbdpRKSUEj/u/LBKUujXhEh6s5NsCblXGIQD7gkM3+EXIHyYwPGLgnBo5B uKdHhy9sQiIy8zJazdRimBsbSwAnTw/FsoiMaM9W2KFSVa3Dq29+MboxNWWK8d3mt+pb JTixXSkS6kDuC81S+/7Mvkh3xCTbbe8bOj3xcscoq2oXe81l6oPdCIgvlNGkMoxGmb3E E6SibrTDGvlpat9VFThFXjjz9CUdpBbzK+bmLWWvs0M1E1DWVHsj5xTlqlMS5ZOt4Gn7 UV3k/Vb67fFrPuwSwAb32ZwWFwM8lkQGqRCa64+WmnCc6FdBtfmY8n4TVREEdQkOyWvx Em7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5/6fz2iVijZBLH9qoGDdtlYZB+7nLsXf0jW6XfihxZM=; b=smWl+QOgbJwXxLwWaH3l92CsNrBDcVITt28NVbWzLltDYOPFoD8gItU85KnHAGeDoD ARWj9DPmIsoCotYGM55pe/iW5FrWGIuyDHnv6+4cY8KXRS9MF8mke+d3mC6xcOB8gHCS ZspTAlDxVNIw+9A/GpaNxJxK4BpXOuHtByygvU65iY+kUJam1pByASs4B+TF562fcvc8 YdS4UngwS32/+02SCmG0subhcIDjyES3QciEdGQ3RrBoit83bsQp6/yI/K6VGOxd3Md8 Ild9Ie5ZewhHIQfOGcsaT6aYfRKBHl9wlEXJvtEGTAJVFBokuvIk6JY+rwzsmYTl7tXA v9hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HxyHwknU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k33si69166439pld.374.2019.01.09.08.45.08; Wed, 09 Jan 2019 08:45:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HxyHwknU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732723AbfAIQXe (ORCPT + 99 others); Wed, 9 Jan 2019 11:23:34 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34706 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731100AbfAIQXe (ORCPT ); Wed, 9 Jan 2019 11:23:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5/6fz2iVijZBLH9qoGDdtlYZB+7nLsXf0jW6XfihxZM=; b=HxyHwknUKddEykZ+nqMjhA8Vp jnwyDuTbwFw/avrvoFn3L/zedBkYJMd0d1Z8DxQ7NWEsD7m8p3ZzG12k3zRYtgG9y9tGqnP4s8B8/ b5GWFzEQJ95qJevApF5YZp8+taUrhmE9/2sXsk/gsncFp8IZ/Bxp682cGvE8ITywJqcz9UcWYGbFQ pRhecL9Tsg0QRtP+nhRKobe70RPkr/kMvoyjQXbM5QfaZjCm+WbUutY0exHF5NlfsDHIJm8RHY8D7 Nqy7tol84DZ3Nz5mRh1gcmeGL+DJibmjkUXb7VjSjQ0riIfDuIjUf6vzbKi0LpbnUzcCjBBI88KuC y+K59MqEQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghGdg-0000JW-Qq; Wed, 09 Jan 2019 16:23:32 +0000 Date: Wed, 9 Jan 2019 08:23:32 -0800 From: Matthew Wilcox To: Souptick Joarder Cc: akpm@linux-foundation.org, jglisse@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH] include/linux/hmm.h: Convert to use vm_fault_t Message-ID: <20190109162332.GL6310@bombadil.infradead.org> References: <20190109161916.GA23410@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190109161916.GA23410@jordon-HP-15-Notebook-PC> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2019 at 09:49:17PM +0530, Souptick Joarder wrote: > convert to use vm_fault_t type as return type for > fault handler. I think you'll also need to convert hmm_devmem_fault(). And that's going to lead to some more spots. (It's important to note that this is the patch working as designed. It's throwing up warnings where code *hasn't* been converted to vm_fault_t yet but should have been).