Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] clk: Fix a missing check on regmap_bulk_read
Cc:     kjlu@umn.edu, Marek Vasut <marek.vasut@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     pakki001@umn.edu
In-Reply-To: <20181224190032.23167-1-pakki001@umn.edu>
From:   Stephen Boyd <sboyd@kernel.org>
User-Agent: alot/0.8
References: <20181224190032.23167-1-pakki001@umn.edu>
Message-ID: <154706014175.15366.2565561612277733965@swboyd.mtv.corp.google.com>
Date:   Wed, 09 Jan 2019 10:55:41 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Aditya Pakki (2018-12-24 11:00:32)
> Currently, vc5_pll_recalc_rate() may produce incorrect output when
> regmap_bulk_read() fails. The fix checks the return value of the
> latter function and returns 0 in case of failure.
>=20
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
>  drivers/clk/clk-versaclock5.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> index decffb3826ec..cd76a893c594 100644
> --- a/drivers/clk/clk-versaclock5.c
> +++ b/drivers/clk/clk-versaclock5.c
> @@ -413,7 +413,8 @@ static unsigned long vc5_pll_recalc_rate(struct clk_h=
w *hw,
>         u32 div_int, div_frc;
>         u8 fb[5];
> =20
> -       regmap_bulk_read(vc5->regmap, VC5_FEEDBACK_INT_DIV, fb, 5);
> +       if (regmap_bulk_read(vc5->regmap, VC5_FEEDBACK_INT_DIV, fb, 5))
> +               return 0;

There are a bunch of other regmap_*() APIs in here that "could fail".
Why has this one been chosen but the other ones not?