Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265865AbUA1Ls3 (ORCPT ); Wed, 28 Jan 2004 06:48:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265913AbUA1Ls3 (ORCPT ); Wed, 28 Jan 2004 06:48:29 -0500 Received: from intra.cyclades.com ([64.186.161.6]:52917 "EHLO intra.cyclades.com") by vger.kernel.org with ESMTP id S265865AbUA1Ls2 (ORCPT ); Wed, 28 Jan 2004 06:48:28 -0500 Date: Wed, 28 Jan 2004 09:42:30 -0200 (BRST) From: Marcelo Tosatti X-X-Sender: marcelo@logos.cnet To: Krzysztof Halasa Cc: marcelo.tosatti@cyclades.com, lkml Subject: Re: [TRIVIAL PATCH] 2.4.25pre7 warning fix In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 36 On Tue, 27 Jan 2004, Krzysztof Halasa wrote: > Hi, > > The attached patch fixes the following warning msg: > > time.c:435: warning: `do_gettimeoffset_cyclone' defined but not used > > There is no need to define functions which do just { return 0; } and > which aren't called by anything. > > (In case CONFIG_X86_SUMMIT is defined, there is another (real) > do_gettimeoffset_cyclone() function, and it is referenced - but > it's simply not related to this empty function). Applied, thanks. Btw, why do we need cyclone_setup() for !CONFIG_X86_SUMMIT ? /* No-cyclone stubs */ #ifndef CONFIG_X86_SUMMIT int __init cyclone_setup(char *str) { printk(KERN_ERR "cyclone: Kernel not compiled with CONFIG_X86_SUMMIT, cannot use the cyclone-timer.\n"); return 1; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/