Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CC7BF609D1
Subject: Re: [PATCH v1 2/6] clk: qcom: Skip halt checks on
 gcc_usb3_phy_pipe_clk for 8998
To:     Stephen Boyd <sboyd@kernel.org>, mturquette@baylibre.com
Cc:     bjorn.andersson@linaro.org, andy.gross@linaro.org,
        david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com,
        devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
        balbi@kernel.org, linux-usb@vger.kernel.org
References: <1546620615-2389-1-git-send-email-jhugo@codeaurora.org>
 <154706034090.15366.11081837995313995010@swboyd.mtv.corp.google.com>
From:   Jeffrey Hugo <jhugo@codeaurora.org>
Message-ID: <d99bd2ac-4c35-470e-e19d-e90f091cad4b@codeaurora.org>
Date:   Wed, 9 Jan 2019 12:28:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <154706034090.15366.11081837995313995010@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/9/2019 11:59 AM, Stephen Boyd wrote:
> Quoting Jeffrey Hugo (2019-01-04 08:50:15)
>> The gcc_usb3_phy_pipe_clk is generated by the phy, but is also used by
>> the phy during init.  The clock needs to be enabled during the init
>> sequence, but may not be fully active until after the init sequence is
>> complete.  This causes a catch-22 if the clock status is checked during
>> enable.  As a result, skip the checks to avoid the troubling situation.
> 
> I will ask again, is anyone going to fix this in the phy driver? In
> theory it isn't needed if the phy driver can do things differently, but
> last time I checked I was told that the phy team said it had to be done
> this way.
> 

Interesting.  I was unaware of past discussion(s) on this.  Thank you 
for taking the change, but I'll try having a look to see if maybe I can 
prove your theory going forward.

-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.