Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1158026imu; Wed, 9 Jan 2019 12:43:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN6utCLhtaKdfWuImvtBprVdlX+9iY19W/XxnPt6rHKht/8t2n7ToyA2WyEOdhVtzHOfZY5T X-Received: by 2002:a63:165e:: with SMTP id 30mr6797720pgw.103.1547066585673; Wed, 09 Jan 2019 12:43:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547066585; cv=none; d=google.com; s=arc-20160816; b=v+dZMoR6+wIWve8mokzAcPvOYRm2V9UNL1y7qKM4rQ0i1MDHGKiM38Isy+fSpdDOoe OlKAuJ0m1/ATwOnhEAOS5092BpTocRTF62AQIYyNlccP2V14KjhJpiLYvXkMcv1CxFi+ BUeEMtUmP9dt/bG600YyGpxIQsTUO60rtkGtqlV8PwqFgg9aWfRtF+jgswPX9X95lpJO 9O47WikEdbS/fj3QOV6gRTK5DSoBf9ZVCUDFdTwajTCdUYlSIYmOfSWsoZQST5KqcJiZ Vquqk/AZW21J+t3o57ZNfCxinB7EpLsFggO17n5QFpFLjwCeRjdS0txdW9m04M1YDFRA GDtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=swwKGjlxsCKsDjfNvxqulMIv2gw8hesi3Ugj4h66wwY=; b=owNOLl7czXz4LnnzIZ4y0/sggBBXIaf4aVKwATgn26k3zCWaWi++6RIIGkZ7QAatPO 21mImIUffDQFrLspyy+baHuMi0ndMNsmtKF5EbRs+9p1cnJhng9Cc+u/pU42YUeXHR6y /6gzXM8N6js7KN+q9P/xw9h/+3oHTlyhjt3tabrfZWxaJSlDyj94HS8XV8pCRMjCtJAO o0OerdcQW+x3/kJldoDdoLt1dIuCZmnSmtxYEjxAwMT33XdBYWgVqIsBqeufqrl57N59 BQz7KZL7atxQCBu0MGBL0RaoKLlG1QdjAscmjMe5G0dz2smX1yBVsi1k6FIwkFNfr9oQ dEOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=cutrSAxW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d189si17710139pfa.70.2019.01.09.12.42.50; Wed, 09 Jan 2019 12:43:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=cutrSAxW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727159AbfAISgN (ORCPT + 99 others); Wed, 9 Jan 2019 13:36:13 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:39548 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfAISgN (ORCPT ); Wed, 9 Jan 2019 13:36:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=swwKGjlxsCKsDjfNvxqulMIv2gw8hesi3Ugj4h66wwY=; b=cutrSAxW4NeRuyLooMiefSOm1 eMj3m7pNeUv9BRUNshBlG3nfw1lTzULJoASN5NODq4X6ad906D2U4GozLYZw/dwxR+LQSzDPBt41C ks8zOrtUhFWv6JCPqIGkgnODs0wF/vuZOCYrRJeqnEtRO1YzVnHNyyjKFth5SNUza/4K0=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1ghIhy-0000jZ-7N; Wed, 09 Jan 2019 18:36:06 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id A33391127528; Wed, 9 Jan 2019 18:36:05 +0000 (GMT) Date: Wed, 9 Jan 2019 18:36:05 +0000 From: Mark Brown To: Jon Hunter Cc: Liam Girdwood , Kuninori Morimoto , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Marcel Ziswiler , Matthias Reichl Subject: Re: [PATCH] ASoC: core: Fix deferral of machine drivers Message-ID: <20190109183605.GH10405@sirena.org.uk> References: <1546968494-22993-1-git-send-email-jonathanh@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="svZFHVx8/dhPCe52" Content-Disposition: inline In-Reply-To: <1546968494-22993-1-git-send-email-jonathanh@nvidia.com> X-Cookie: VMS version 2.0 ==> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --svZFHVx8/dhPCe52 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 08, 2019 at 05:28:14PM +0000, Jon Hunter wrote: > --- a/include/sound/soc.h > +++ b/include/sound/soc.h > @@ -925,7 +925,7 @@ struct snd_soc_dai_link { > */ > const char *platform_name; > struct device_node *platform_of_node; > - struct snd_soc_dai_link_component *platform; > + struct snd_soc_dai_link_component platform; > =20 > int id; /* optional ID for machine driver link identification */ > =20 This breaks the build for the SCU cards (and we needs a little rebase against another fix I just merged, though I did do that when applying). I do think that this is going to be the safest thing to do for v5.0, it can always be reverted later on when it's not needed but it seems clear that a better fix is going to be way too invasive for the -rcs. Can you respin and retest please? --svZFHVx8/dhPCe52 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlw2PxQACgkQJNaLcl1U h9DsVQf7Bl7vEBMABSqiIzvDhDkyN+XK0TSjJ3FL2od/a+726iim+xXCPWWPX3lH gJpGNqEdpUOoOHmF/vdJG+mXCgDZIWQNcno7WS2NXKxZTuR7nGq7jlEVPhCMB7uz 03p1MsAS9cgejzohTErsCKcgcGpdRvaJe+WyNwu4uQK5vaOFoS8e9VnP+RiLo3gQ aQR0Gqxw4C3CwZZt7abSfwB/Y20gJ8xFreTAJOqAoqMQV4R4KOU0Wqmou2pYzLGW D4CRr53m1xD1F4E2v+i/XvpHJ+FGRYkv287tj05kdaCgRQzsCMuYuZUw1wymXq/t BszRVWAPqyfTHsJk+jTrcHlYroKyJQ== =oZNb -----END PGP SIGNATURE----- --svZFHVx8/dhPCe52--