Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1163493imu; Wed, 9 Jan 2019 12:50:16 -0800 (PST) X-Google-Smtp-Source: ALg8bN6CJwWAkIu+orWTGNp/UY2WatzFt0dmmiAla/fjHhdUFIOn1HB8bqCLuNp4v9XjCSA9Qzrh X-Received: by 2002:a62:824c:: with SMTP id w73mr7438439pfd.150.1547067016109; Wed, 09 Jan 2019 12:50:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547067016; cv=none; d=google.com; s=arc-20160816; b=GlEACq0VzQjNQupWnPLUmzEzX5HZNioa3LtZ0ZUQ4v6HzRap9Tkpyp2BUNYiHb/r7h 4zHy2CzOOrQwD4XjcxyQS6dbzr5+oenbyuNUMA9wLLggG835L7y+YncNh37vnfblRK06 vwsWUbU+RbnSU/3XP6nepPymQGAte6aEFEPGA2FQ+Sd+B+s6KoK6lYAJQ9A5I5I93N2H M42zbHHZs2p3DCbN0G7E3HPBh6nOw5RrILCOgwMOLBSHLsg9lCkKT7poc6UcHrb4x153 kriJvrgyTvkVFHw3lUmz0gAPJzVm1psZKo2a8nsi1LX6bNryde/HH4YYMXt6BdtqQm5h 6cTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hKyL4CfL7YSUjp0Dl0YOxZy+BWcnp2DvLGJ9XkgMYR4=; b=HebgxFPjc03qkL1MdF2uMZRAZ6nlAOhOyjATJ0gFskvJRfS5RGBrE9IYEqSllr2ef2 qlV7DQ4funyDXBXK4cc5oQq+ATmKJ4Vkd7crimgbV6K7EMw70RdFJTC47RbhEmDwVOOT VHeWBjMgxOAkwZ8/9ojEahAm7xBiCd66XGpGyTYPaWgYYJaIfOTgrmBxqubMOl8nJOlK Dqbxl/SY4RJXY6aIfCzYLh9OReBt37ZkEJa8K7mYdA3Ln4Ba3ZWuuVg137tkfggcQS96 FwAsS0NnW5uTFH0CUOz0l3qeZ/q/rJo4ucZq6Np5lj8ElfTqpUy9suFjkQLNwpJlOIh3 J/jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=LkkGaiVC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p22si67906768pgl.340.2019.01.09.12.50.01; Wed, 09 Jan 2019 12:50:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=LkkGaiVC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbfAISvE (ORCPT + 99 others); Wed, 9 Jan 2019 13:51:04 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:36330 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbfAISvE (ORCPT ); Wed, 9 Jan 2019 13:51:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hKyL4CfL7YSUjp0Dl0YOxZy+BWcnp2DvLGJ9XkgMYR4=; b=LkkGaiVCgD13wGa0Otq7kEuJP yTBDaI36Go73N4kwiEPCiVI35F9fF83OEewahVfGQOJa3ckr0NKPpmzB97kfr8JbFBtkQGbThsVe9 vbewzbS2q/LU9OMCa+TAruCFWT//eyk6dVHj7kAv83mNutYQiqgcZEDUWSXd6jL61us0M=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1ghIwM-0000ks-Mg; Wed, 09 Jan 2019 18:50:58 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 542661127528; Wed, 9 Jan 2019 18:50:58 +0000 (GMT) Date: Wed, 9 Jan 2019 18:50:58 +0000 From: Mark Brown To: Chen-Yu Tsai Cc: Code Kipper , Maxime Ripard , linux-sunxi , linux-arm-kernel , Liam Girdwood , linux-kernel , Linux-ALSA , "Andrea Venturi (pers)" Subject: Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask Message-ID: <20190109185058.GL10405@sirena.org.uk> References: <20181221152110.17982-1-codekipper@gmail.com> <20181221152110.17982-5-codekipper@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t5C3/nrmPumNj5sH" Content-Disposition: inline In-Reply-To: X-Cookie: VMS version 2.0 ==> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --t5C3/nrmPumNj5sH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Dec 22, 2018 at 12:54:48AM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 21, 2018 at 11:21 PM wrote: > > Also add offset to RX channel select > Commit log seems a bit lacking. You could probably explain how you > found this, either when comparing datasheet macros, or some actual > error manifested and you "heard" it. You could also state what the > fixed outcome should be. > Also please add a fixes tag. Plus send this at the start of the series so it can be applied as a fix and sent to Linus during the development cycle. --t5C3/nrmPumNj5sH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlw2QpEACgkQJNaLcl1U h9A/2Qf+MpKvC1sDIcOBBmk7hZNPdkcZE5wlhCQAmahqcAdv8UeXEo+DGX8UwwtV 4DI7HFayI95aRYebTz5VK/W1noETZaQMciZ8eeqELS95MInDMhauwlioR0QlN90L re/xxB9i+h/rGYomJenLE4UblW9FQ9D92bIudL7aSW+ysnEJFvptf3e6IVYwWGBH Oh3H2N35iCCVsO45ex6Ra2k4h5/zDqz8jqM3MrlDN0AAb5OmT76HHWfiCNPTNZyU hty4A7sssYji0nqfs3gB6UqJwK4eAxjGak6tmh5yHu02WXh+4HQjMMpnQfvYVdX3 RUFMDvm2f2KaEaljyksXH4Wml+pKAw== =REGU -----END PGP SIGNATURE----- --t5C3/nrmPumNj5sH--