Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1191154imu; Wed, 9 Jan 2019 13:20:43 -0800 (PST) X-Google-Smtp-Source: ALg8bN52skVdtOv3jI+tLHeWCcLJURC+ivyvig9KeQ+P7HyVgWldKR9mAyHmJEGVYGoqqYO2NpGV X-Received: by 2002:a63:2c82:: with SMTP id s124mr6738459pgs.73.1547068843088; Wed, 09 Jan 2019 13:20:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547068843; cv=none; d=google.com; s=arc-20160816; b=jiTEwhaIEyI8ZhMmjIccGjj4ZaffSyQfNw3WSrXLvHT3/EWsB276s8t0gwxhlR9Uv9 Hjoov6dZPgy2hlPPXT7/Ga/c2r0iW8D3/MTm4QDLYmw32rq8oR4qadFgxA1z2coAJJOS 9fTY8AWJPpPzzuoq2Ww3LR2UMsZ+Md4JfW3GXV46LpG8hDKbLWIuVMgsRF3mYkZ0vcxl A+Byx8gePUW0eGcxF7rGrRCm1qxDQaTLY+CzZiMcf7smXREUoYWraqZQZ2xdaZFVDvlf t6OnZDuYjHViPZZG8L5CZ9iJjYRm/IpUPtOznqnqJ5ZYItTgTVGW4TqQEOk8UcmY8BPo 83Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=sRsctgs/MKjtsDffpi7F+j5tWCNGL+iCrIv91bo5obs=; b=ggd/++LWm5ijUB6jibAMvkfglLMLFxTj5SkWx47r0cTUMAllPAyvzNhfqqcpLw/5EB DxfjDVEDKjEa6BC4gVXjMVw5CRcySfG5oGNKOIa0MfYx/Yr9e2cBqRDIvn/5fB2IO4rq S2GJco0whYVPE2ewdFpe7c8rSmz8Y8QAykJOd9ecCMVpf8m5nJ0p5tRVRuafk8rerQEA u1TR1LjhFssmFSdot1herFb0uRYaz6DK4JufTswuqPStlb0MtUmkEhrEK3bRhGnCYmtp osSzBR+zQ8Od1g9qyQPHIrAKuYvfqo7yQtPKYqhnsPAlupr435/VN0iV9jVtxH6DV4dK hnlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t9si45983942plq.337.2019.01.09.13.20.28; Wed, 09 Jan 2019 13:20:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbfAISlG (ORCPT + 99 others); Wed, 9 Jan 2019 13:41:06 -0500 Received: from verein.lst.de ([213.95.11.211]:43377 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbfAISlG (ORCPT ); Wed, 9 Jan 2019 13:41:06 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 286EA68DD2; Wed, 9 Jan 2019 19:41:05 +0100 (CET) Date: Wed, 9 Jan 2019 19:41:05 +0100 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Intel SCU Linux support , Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , Christoph Hellwig , Jens Axboe , Jeff Moyer Subject: Re: [PATCH] scsi: isci: initialize shost fully before calling scsi_add_host() Message-ID: <20190109184105.GB22070@lst.de> References: <20190108205043.3122-1-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190108205043.3122-1-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This looks good. I wonder if there is any good way to prevent other drivers from picking up this bug byt using a better interface, but that should not delay your fix.