Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1547067088.83374.41.camel@acm.org>
Subject: Re: [PATCH v3] loop: drop caches if offset or block_size are changed
From:   Bart Van Assche <bvanassche@acm.org>
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Date:   Wed, 09 Jan 2019 12:51:28 -0800
In-Reply-To: <20181218224139.GB31062@jaegeuk-macbookpro.roam.corp.google.com>
References: <20181214203223.7063-1-jaegeuk@kernel.org>
         <20181217194236.GA50659@jaegeuk-macbookpro.roam.corp.google.com>
         <29369548-df14-a5a7-2bee-a40b3479df68@kernel.dk>
         <20181218224139.GB31062@jaegeuk-macbookpro.roam.corp.google.com>
Content-Type: text/plain; charset="UTF-7"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2018-12-18 at 14:41 -0800, Jaegeuk Kim wrote:
+AD4 +AFs ... +AF0

Please post new versions of a patch as a new e-mail thread instead of
as a reply to a previous e-mail.

+AD4 +AFs ... +AF0
+AD4
+AD4  	if (lo-+AD4-lo+AF8-offset +ACEAPQ info-+AD4-lo+AF8-offset +AHwAfA
+AD4  	    lo-+AD4-lo+AF8-sizelimit +ACEAPQ info-+AD4-lo+AF8-sizelimit) +AHs
+AD4 +-		/+ACo kill+AF8-bdev should have truncated all the pages +ACo-/
+AD4 +-		if (lo-+AD4-lo+AF8-device-+AD4-bd+AF8-inode-+AD4-i+AF8-mapping-+AD4-nrpages) +AHs
+AD4 +-			err +AD0 -EAGAIN+ADs
+AD4 +-			goto exit+ADs
+AD4 +-		+AH0

Please add a pr+AF8-info() or pr+AF8-warn() statement here such that it becomes
easy for the user to figure out why EAGAIN has been returned.

+AD4  	blk+AF8-mq+AF8-freeze+AF8-queue(lo-+AD4-lo+AF8-queue)+ADs
+AD4  
+AD4 +-	/+ACo kill+AF8-bdev should have truncated all the pages +ACo-/
+AD4 +-	if (lo-+AD4-lo+AF8-queue-+AD4-limits.logical+AF8-block+AF8-size +ACEAPQ arg +ACYAJg
+AD4 +-			lo-+AD4-lo+AF8-device-+AD4-bd+AF8-inode-+AD4-i+AF8-mapping-+AD4-nrpages) +AHs
+AD4 +-		err +AD0 -EAGAIN+ADs
+AD4 +-		goto out+ADs
+AD4 +-	+AH0

Same comment here. Additionally, please consider renaming the +ACI-out+ACI label
into +ACI-unfreeze+ACI or so. I think that will make the use of label names more
consistent with the rest of the block layer. Once these two comments are
addressed, feel free to add:

Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4