Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1546593547-24406-1-git-send-email-peng.hao2@zte.com.cn>
In-Reply-To: <1546593547-24406-1-git-send-email-peng.hao2@zte.com.cn>
From:   Paul Moore <paul@paul-moore.com>
Date:   Wed, 9 Jan 2019 19:54:18 -0500
Message-ID: <CAHC9VhTpHNxFUR7OP+=cVPiFOTw33ptrV89HPCORo4bvMQFc-g@mail.gmail.com>
Subject: Re: [PATCH] security/selinux/hooks: remove unneeded semicolon
To:     Peng Hao <peng.hao2@zte.com.cn>
Cc:     Stephen Smalley <sds@tycho.nsa.gov>,
        Eric Paris <eparis@parisplace.org>,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, selinux@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 3, 2019 at 7:55 PM Peng Hao <peng.hao2@zte.com.cn> wrote:
>
> Remove unneeded semicolon.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index a67459e..73c679e 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -1263,7 +1263,7 @@ static void selinux_write_opts(struct seq_file *m,
>                 default:
>                         BUG();
>                         return;
> -               };
> +               }
>                 /* we need a comma before each option */
>                 seq_putc(m, ',');
>                 seq_puts(m, prefix);

Thank you for your patch, but the selinux_write_opts() function was
just removed in v5.0-rc1 in commit e3489f8974e1 ("selinux: kill
selinux_sb_get_mnt_opts()").

-- 
paul moore
www.paul-moore.com