Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1547106068.7403.17.camel@suse.com>
Subject: Re: [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header
From:   Oliver Neukum <oneukum@suse.com>
To:     Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
        gregkh@linuxfoundation.org, stern@rowland.harvard.edu
Cc:     brajeswar.linux@gmail.com, jrdr.linux@gmail.com,
        usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date:   Thu, 10 Jan 2019 08:41:08 +0100
In-Reply-To: <5c36f533.1c69fb81.253c8.2646@mx.google.com>
References: <5c36f533.1c69fb81.253c8.2646@mx.google.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Do, 2019-01-10 at 13:03 +0530, Sabyasachi Gupta wrote:
> Remove unusual_jumpshot.h which is included more than once.
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
>  drivers/usb/storage/jumpshot.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
> index 917f170..06e46c6 100644
> --- a/drivers/usb/storage/jumpshot.c
> +++ b/drivers/usb/storage/jumpshot.c
> @@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
>  }
>  
>  static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
> -#	include "unusual_jumpshot.h"
>  	{ }		/* Terminating entry */
>  };
>  

NACK.

It is included twice because the same device needs to be specified
and is quirky. You are breaking the driver.

	Regards
		Oliver