Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1672526imu; Thu, 10 Jan 2019 00:40:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN4DNKbsrFAwUtTRY+YLI8QOOVrmirA1TVFbVtJrhGJmej06nLG5vobFhhrQPS61leM0CjxO X-Received: by 2002:a62:53c5:: with SMTP id h188mr9205436pfb.190.1547109637483; Thu, 10 Jan 2019 00:40:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547109637; cv=none; d=google.com; s=arc-20160816; b=Vttg3AwdVmM0v208C5M3dz/yEiXUBQ9jempybQ1Qx/oMWFmNLSKhSHH+TOaz7LSuwn r2XC/hRRu2sbMB2BGvcmE06KR8ROy1zQDYCrgerNWcfjBr5mLYeyV7rlG9Gr4m3ojX0O 1QL8rodqS9IZf1Dro9Jtb2kyZf3v7jeTC87pxal4cYTiFJHfQ2ijJYlKc4spz3iuAT6S y4lyXD3kUTkWXhQx6P8ZB9RV7Icxjttt3WI6ED+CFb4RPfKdYPlqZxtzwIQeFnWZofhP mvNtfi6qNc4Ihm8pd+FMombWd1EkNfHDB0kq6N58YQ39iI8X/Xf8UA5D7L7xqXp0Augs 59WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fzJWWhVhoQ53zvh9P9pc3UFm4hIku4H1tEhsKDoVCAM=; b=nldzjfa0g59Vda+Gz7E5/4yomIjURSJ7/3v30cDX4mC1/prcJMbcEk+nrETRU8exKu GP2pO35gviGcrAaGd15By8OxWHUql/pYMlYWLAZZaed6lRy9aEGdCJ+hNFKVEO+HA/4d 9qq5xqqH1xJRTewu+tKC0uF4aAneeR8nk4t1snIRYPxyTRDu0nhkgCg+au4+58Hkj4+y CtCUxG99dwlYkA9NnQyd55/GMSDW67umAAKEVW3SFwow0VuznPyIk85Rry/+Tcqk7QNi aEvSlRyskaEwg1ATOPNzG6xrYBsOlSTirSKV/LQUQvvF51q2AMYcAAdC99oXG3aHdYWh uL0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Vkhg5iOc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si9931816pgs.96.2019.01.10.00.40.22; Thu, 10 Jan 2019 00:40:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Vkhg5iOc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbfAJIhE (ORCPT + 99 others); Thu, 10 Jan 2019 03:37:04 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44407 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbfAJIhD (ORCPT ); Thu, 10 Jan 2019 03:37:03 -0500 Received: by mail-pf1-f194.google.com with SMTP id u6so4976529pfh.11 for ; Thu, 10 Jan 2019 00:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fzJWWhVhoQ53zvh9P9pc3UFm4hIku4H1tEhsKDoVCAM=; b=Vkhg5iOcNaoLDfnEdTDGsDcg3xX8ZNV0xbeizayZ+hKjQ7SI87p1ylIOB9Wt+FSynK GntqVziQOvupttR7fsMESEThG+JWNx9oKI8nsevBkh+2QgdL+PXzhAs+OpqOr9lAuyYd ll2cjzEelNSWFKe6nZ9w3F9K2j5nPSMBPtH6zUkC6cd2XiuusfqBHmCQQQKEtNPmFUEE dZZMiMR7gZp49v40Zj26BFF80faWIcat7lmIL0G61OEK/s1QS4UzL2M6xeskGPOw1La0 7isCX2K1nQKDRkQ0Ou5dqPmhNhEmqMaFWL3KV0SP7RLjCxf6Y8cZJtT2Uy+e4fhRtZGw ogMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fzJWWhVhoQ53zvh9P9pc3UFm4hIku4H1tEhsKDoVCAM=; b=WC00qLAdlnt5xBo82AWOzoZS9yGuXpuweGE/D0WiMJ4MoyaO0VZO22IF6zE0wIkeIN ZBdDeluz9M13abIeTErFS2jDVqHOYDyRN2u5RYwLi8KMWQCfMfXwXLUp6u5v86dFU1n6 jaeiJcVJQODvJVIK+//r9HqcT2whwSr3Me6oAW1RDxvXECCy1Ok322zZvF51MlGSyma3 gj4DchT4wUug7WcEQ5bc+rWnLDwU3k4Cl8fKj68kiAxEHf9Wpw3d7aallmf2ZewB1ak3 aNftNO/POftgverQpAnMBf6B8sqMn4TQI16fsxP9bBSAHQF3WeenOH8OP1NUEWEy8Hhg kkdg== X-Gm-Message-State: AJcUukfsjEa+fQ4amGFQ7MBobmsfsGUjlBniByeycBIyU6/v3UJmgyEU OmaYLnosUGool7cUh9EY24Unwyn5 X-Received: by 2002:a62:5301:: with SMTP id h1mr9261121pfb.17.1547109422124; Thu, 10 Jan 2019 00:37:02 -0800 (PST) Received: from gmail.com (c-73-140-212-29.hsd1.wa.comcast.net. [73.140.212.29]) by smtp.gmail.com with ESMTPSA id 196sm293228929pfc.77.2019.01.10.00.37.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 00:37:01 -0800 (PST) Date: Thu, 10 Jan 2019 00:36:59 -0800 From: Andrei Vagin To: Oleg Nesterov Cc: Andrew Morton , linux-kernel@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH] kernel: release ptraced tasks before zap_pid_ns_processes Message-ID: <20190110083658.GA11083@gmail.com> References: <20190102205939.26231-1-avagin@gmail.com> <20190108165043.GA10240@redhat.com> <20190108203612.GA19454@gmail.com> <20190109170829.GA15302@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20190109170829.GA15302@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2019 at 06:08:30PM +0100, Oleg Nesterov wrote: > On 01/08, Andrei Vagin wrote: > > > > No, you don't. The patch looks really nice. Thanks! > > > > BTW: We probably need to add the "Fixes:" tag, but I am not sure to which > > commit, it looks like the issue is here for years. > > I hate you ;) I know :) > Ok, OK, this was broken by me in 7c8bd2322c7fd973d089b27de55e29c92c667a06 > "exit: ptrace: shift "reap dead" code from exit_ptrace() to forget_original_parent()" > > > Acked-by: Andrei Vagin > > Thanks, but if you agree with this patch may I ask you to send v2? > > You found the real problem, my version is only slightly better than yours, > I don't want to steal the "From" tag. Feel free to add mine signed-of-by. Thanks Oleg! I will send a second version of this patch. > > Oleg. >